feat(compiler): support for CustomStateSet #6286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #6285
Stencil Version
4.33
Current Behavior
@AttachInternals() internals!: ElementInternals;
cannot be used without
formAssociated: true
in the metadata.because of a condition in the compiler
Expected Behavior
@AttachInternals() internals!: ElementInternals;
should work without
formAssociated: true
in the metadata.CustomStateSet can now be used without formAssociated for components that are not formAssociated.
Improvement: Add stencil support for custom state.
System Info
Steps to Reproduce
add
@AttachInternals() internals!: ElementInternals;
to a component, an console error will be shown
Code Reproduction URL
Additional Information
Will commit a fix for it, the solution is quite easy:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/attachInternals
Does this introduce a breaking change?
Testing
Manual testing / changing code in
node_modules