Update resolvers to use state change's toID and order
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a custom resolver for the StateChange.id field, generating a composite ID from ToID and StateChangeOrder for compatibility. Updates all relevant tests and loader keys to use the new composite ID, and modifies the GraphQL schema to require the resolver for the id field.
Eliminates the 'id' field from the StateChange GraphQL type, its resolver, and all associated complexity and execution logic. Updates tests to no longer reference or expect the 'id' field, focusing instead on 'accountId' and 'stateChangeCategory'. This simplifies the schema and code by removing the composite ID previously generated from ToID and StateChangeOrder.
Updated operations and transactions logic to use (to_id, state_change_order) composite keys instead of single string IDs for state changes. Modified related queries, test data, and dataloader logic to support this change. Added a utility function to parse composite state change IDs.
Changed the StateChange.operation field from non-nullable to nullable in the GraphQL schema and regenerated code accordingly. This allows StateChange objects to have a null operation, improving flexibility in the API.
Modified StateChangeModel to always return to_id and state_change_order as primary keys and updated the query ordering. Improved the Clone method in StateChangeBuilder for correctness. Clarified in the GraphQL schema and generated code that the operation field is nullable for fee state changes.
akcays
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
(to_id, state_change_order)primary key for state change.Why
We recently added a new primary key to uniquely identify state changes. The
to_id, state_change_ordernow acts as the ID for a state change.Known limitations
N/A
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release