Remove tx/create-sponsored-account endpoint
#267
+6
−925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akcays
force-pushed
the
remove-tx/create-sponsored-account
branch
from
f2a025a to
a413f8f
Compare
akcays
force-pushed
the
remove-tx/create-sponsored-account
branch
from
a413f8f to
830dd18
Compare
This was referenced Aug 11, 2025
aditya1702
approved these changes
Aug 12, 2025
|
|
||
| return txe, s.ChannelAccountSignatureClient.NetworkPassphrase(), nil | ||
| } | ||
|
|
||
| // WrapTransaction wraps a stellar transaction with a fee bump transaction with the configured distribution account as the fee account. | ||
| func (s *accountSponsorshipService) WrapTransaction(ctx context.Context, tx *txnbuild.Transaction) (string, string, error) { |
There was a problem hiding this comment.
I think we should move WrapTransaction from here since its only used for creating fee-bump txns. Will leave it up to you to do it in this PR or the create-fee-bump one, and then completely delete this file
There was a problem hiding this comment.
Good callout! I agree that it would be ideal to move WrapTransaction, and remove account_sponsorship_service.
I was planning on moving it into it's own service (i.e. feeBumpService), with create-fee-bump but doing it in this PR will be cleaner/easier to review as create-fee-bump will also include the migration logic.
| @@ -8,63 +8,16 @@ import ( | |||
| "github.com/stellar/go/txnbuild" | |||
There was a problem hiding this comment.
You should also remove the endpoint from the openapi/main.yaml file
akcays
force-pushed
the
remove-tx/create-sponsored-account
branch
from
830dd18 to
883d48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes:
- Removes
SponsorAccountCreationmethod fromAccountHandler- Removes route definition
- Removes
SponsorAccountCreationRequeststruct- Removes
SponsorAccountCreationTransactionmethod from the interface and implementation- Removes unused constants:
ErrAccountAlreadyExists,ErrSponsorshipLimitExceeded,CreateAccountTxnTimeBounds,CreateAccountTxnTimeBoundsSafetyMargin- Removes
TestAccountHandlerSponsorAccountCreationfrom account_handler_test.go- Removes
TestAccountSponsorshipServiceSponsorAccountCreationTransactionfrom account_sponsorship_service_test.go- Updates remaining test to use simplified service options
- Removes method from
AccountSponsorshipServiceMock- Clean up imports
- Removes unused variables and struct fields
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
N/A
Issue that this PR addresses
#233
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release