Pass encoded Soroban changes to C++ in strict footprint order. - #5421
Open
dmkozh wants to merge 1 commit into
Open
Pass encoded Soroban changes to C++ in strict footprint order.#5421dmkozh wants to merge 1 commit into
dmkozh wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes protocol-28 Soroban change application by preserving footprint order and removing hash-map bookkeeping.
Changes:
- Emits RW changes in footprint order, followed by TTL updates.
- Adds ordered C++ application logic while retaining legacy behavior.
- Moves parallel-apply entries instead of copying them.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/transactions/ParallelApplyUtils.cpp |
Moves entries into the thread map. |
src/transactions/InvokeHostFunctionOpFrame.cpp |
Applies ordered Soroban ledger changes. |
src/rust/src/soroban_proto_any.rs |
Encodes host effects in footprint order. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This allows us to get rid of a hash map used for marking non-deleted RW keys, which saves us a few ms of apply time. This change naturally comes from the refactoring done in p28 which caused host to operate on data in footprint order. Thus this is a non-breaking change that uses p28 host as is. Also includes a passing-by copy->move optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows us to get rid of a hash map used for marking non-deleted RW keys, which saves us a few ms of apply time.
This change naturally comes from the refactoring done in p28 which caused host to operate on data in footprint order. Thus this is a non-breaking change that uses p28 host as is.
Also includes a passing-by copy->move optimization.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)