Skip to content

feat: add logic for eager evaluation of additional expression types #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: add logic for eager evaluation of additional expression types #5053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion lib/node_modules/@stdlib/repl/lib/eager_evaluator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,13 @@ var ANSI_RESET = ANSI_COLORS[ 'reset' ];
* @returns {boolean} boolean indicating whether the node is side-effect-free
*/
function traverse( node ) {
var properties;
var fname;
var i;
if ( !node ) {
return false;
}
if ( node.type === 'Literal' || node.type === 'Identifier' ) {
if ( node.type === 'Literal' || node.type === 'Identifier' || ( node.type === 'UnaryExpression' && node.operator !== 'delete' ) ) {
return true;
}
if ( node.type === 'BinaryExpression' ) {
Expand All @@ -96,6 +97,21 @@ function traverse( node ) {
}
return true;
}
} else if ( node.type === 'ArrayExpression' ) {
for ( i = 0; i < node.elements.length; i++ ) {
if ( !traverse( node.elements[ i ] ) ) {
return false;
}
}
return true;
} else if ( node.type === 'ObjectExpression' ) {
for ( i = 0; i < node.properties.length; i++ ) {
properties = node.properties;
if ( !traverse( properties[ i ].key ) || !traverse( properties[ i ].value ) ) {
return false;
}
}
return true;
}
return false;
}
Expand Down