Skip to content

Conversation

manvith2003
Copy link
Contributor

@manvith2003 manvith2003 commented Dec 17, 2024

Resolves #3774

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/normal/logcdf along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/normal/logcdf $\color{green}325/325$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}325/325$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for stats/base/dists/normal/logcdf feat: add C implementation for stats/base/dists/normal/logcdf Dec 18, 2024
@Planeshifter Planeshifter self-requested a review January 15, 2025 01:55
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 21, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 21, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small edits, but looks good overall!

@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label May 10, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels May 10, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 18, 2025
Planeshifter
Planeshifter previously approved these changes Jun 18, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to land now. Excited to get it in!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 18, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 18, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/normal/logcdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3988
Closes: https://github.com/stdlib-js/stdlib/issues/3774

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes Jun 18, 2025
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit cf30373 into stdlib-js:develop Jun 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: In Progress Pull request is currently awaiting automation. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/normal/logcdf
3 participants