Skip to content

chore!: use single alchemy api key for all chains #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dlipicar
Copy link
Contributor

@dlipicar dlipicar commented Jul 11, 2025

status-desktop PR: status-im/status-desktop#18345
Blocked by: status-im/status-desktop#18346

Replace multiple API keys for Alchemy (one per chain) with a single one, according to https://www.alchemy.com/blog/the-future-is-multichain

Copy link

github-actions bot commented Jul 11, 2025

Looks like you have BREAKING CHANGES in your PR.
Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

@status-im-auto
Copy link
Member

status-im-auto commented Jul 11, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3970817 #1 2025-07-11 18:37:18 ~2 min android 📦aar
✔️ 3970817 #1 2025-07-11 18:38:11 ~3 min linux 📦zip
✔️ 3970817 #1 2025-07-11 18:39:08 ~4 min macos 📦zip
✔️ 3970817 #1 2025-07-11 18:39:37 ~4 min ios 📦zip
✔️ 3970817 #1 2025-07-11 18:40:03 ~4 min windows 📦zip
✔️ 3970817 #1 2025-07-11 18:40:18 ~5 min macos 📦zip
✔️ 3970817 #1 2025-07-11 18:42:11 ~6 min tests-rpc 📄log
✔️ 3970817 #1 2025-07-11 18:45:17 ~10 min linux 📦zip
✖️ 3970817 #1 2025-07-11 19:00:01 ~24 min tests 📄log
✔️ 6071c84 #2 2025-07-15 13:46:10 ~2 min android 📦aar
✔️ 6071c84 #2 2025-07-15 13:47:27 ~3 min linux 📦zip
✔️ 6071c84 #2 2025-07-15 13:48:57 ~4 min macos 📦zip
✔️ 6071c84 #2 2025-07-15 13:50:26 ~6 min ios 📦zip
✔️ 6071c84 #2 2025-07-15 13:51:39 ~7 min tests-rpc 📄log
✔️ 6071c84 #2 2025-07-15 13:51:56 ~7 min windows 📦zip
✔️ 6071c84 #2 2025-07-15 13:52:21 ~8 min macos 📦zip
✔️ 6071c84 #2 2025-07-15 13:54:58 ~11 min linux 📦zip
✔️ 6071c84 #2 2025-07-15 14:09:23 ~25 min tests 📄log

Copy link
Contributor

@friofry friofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vkjr
Copy link
Contributor

vkjr commented Jul 15, 2025

@dlipicar, thanks looks good!
Is there a corresponding status-desktop PR?

Also right now I have 2 env vars set:
STATUS_BUILD_ALCHEMY_OPTIMISM_MAINNET_TOKEN and STATUS_BUILD_ALCHEMY_ARBITRUM_MAINNET_TOKEN. They both have different values. Which one of them should I use later when client will use single token?

@dlipicar
Copy link
Contributor Author

dlipicar commented Jul 15, 2025

@dlipicar, thanks looks good! Is there a corresponding status-desktop PR?

Also right now I have 2 env vars set: STATUS_BUILD_ALCHEMY_OPTIMISM_MAINNET_TOKEN and STATUS_BUILD_ALCHEMY_ARBITRUM_MAINNET_TOKEN. They both have different values. Which one of them should I use later when client will use single token?

any of them will do.

Added status-desktop PR to the description

@dlipicar dlipicar force-pushed the chore/use-single-alchemy-api-key branch from 3970817 to 6071c84 Compare July 15, 2025 13:43
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.22%. Comparing base (f73ae4c) to head (6071c84).

Files with missing lines Patch % Lines
...s/wallet/thirdparty/collectibles/alchemy/client.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6747      +/-   ##
===========================================
+ Coverage    59.94%   60.22%   +0.27%     
===========================================
  Files          820      820              
  Lines       100734   100717      -17     
===========================================
+ Hits         60382    60652     +270     
+ Misses       32765    32461     -304     
- Partials      7587     7604      +17     
Flag Coverage Δ
functional 29.56% <45.45%> (+0.59%) ⬆️
unit 56.86% <72.72%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/defaults.go 75.90% <100.00%> (-1.37%) ⬇️
params/config.go 66.43% <ø> (ø)
protocol/requests/create_account.go 33.33% <ø> (ø)
services/wallet/service.go 81.74% <100.00%> (-7.47%) ⬇️
...s/wallet/thirdparty/collectibles/alchemy/client.go 25.29% <62.50%> (-2.13%) ⬇️

... and 61 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants