-
Notifications
You must be signed in to change notification settings - Fork 258
chore!: use single alchemy api key for all chains #6747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like you have BREAKING CHANGES in your PR. Check-list
|
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@dlipicar, thanks looks good! Also right now I have 2 env vars set: |
any of them will do. Added status-desktop PR to the description |
3970817
to
6071c84
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6747 +/- ##
===========================================
+ Coverage 59.94% 60.22% +0.27%
===========================================
Files 820 820
Lines 100734 100717 -17
===========================================
+ Hits 60382 60652 +270
+ Misses 32765 32461 -304
- Partials 7587 7604 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
status-desktop PR: status-im/status-desktop#18345
Blocked by: status-im/status-desktop#18346
Replace multiple API keys for Alchemy (one per chain) with a single one, according to https://www.alchemy.com/blog/the-future-is-multichain