Skip to content

Conversation

dlipicar
Copy link
Contributor

Replace use of the deprecated connection/status module with the healthmanager.
Events are now transmitted to the client as a separate signal instead of a wallet.Event.

Part of ##6744

@dlipicar dlipicar requested a review from friofry as a code owner July 10, 2025 20:17
Copy link

github-actions bot commented Jul 10, 2025

Looks like you have BREAKING CHANGES in your PR.
Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

@status-im-auto
Copy link
Member

status-im-auto commented Jul 10, 2025

Jenkins Builds

Click to see older builds (72)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ d695900 #1 2025-07-10 20:19:56 ~1 min tests 📄log
✔️ d695900 #1 2025-07-10 20:20:18 ~2 min android 📦aar
✔️ d695900 #1 2025-07-10 20:20:46 ~2 min linux 📦zip
✔️ d695900 #1 2025-07-10 20:21:51 ~3 min macos 📦zip
✔️ d695900 #1 2025-07-10 20:22:25 ~4 min ios 📦zip
✔️ d695900 #1 2025-07-10 20:22:47 ~4 min windows 📦zip
✔️ d695900 #1 2025-07-10 20:23:00 ~5 min macos 📦zip
✔️ d695900 #1 2025-07-10 20:25:54 ~7 min tests-rpc 📄log
✔️ d695900 #1 2025-07-10 20:28:10 ~10 min linux 📦zip
✖️ 13eaded #2 2025-07-11 18:12:55 ~1 min tests 📄log
✔️ 13eaded #2 2025-07-11 18:13:53 ~3 min android 📦aar
✔️ 13eaded #2 2025-07-11 18:13:54 ~3 min linux 📦zip
✔️ 13eaded #2 2025-07-11 18:14:05 ~3 min macos 📦zip
✔️ 13eaded #2 2025-07-11 18:15:29 ~4 min ios 📦zip
✔️ 13eaded #2 2025-07-11 18:16:08 ~5 min macos 📦zip
✔️ 13eaded #2 2025-07-11 18:16:08 ~5 min windows 📦zip
✔️ 13eaded #2 2025-07-11 18:18:26 ~7 min tests-rpc 📄log
✔️ 13eaded #2 2025-07-11 18:20:21 ~9 min linux 📦zip
✖️ 5a8f7b3 #3 2025-07-14 18:40:34 ~2 min tests 📄log
✔️ 5a8f7b3 #3 2025-07-14 18:40:57 ~2 min android 📦aar
✔️ 5a8f7b3 #3 2025-07-14 18:41:03 ~2 min linux 📦zip
✔️ 5a8f7b3 #3 2025-07-14 18:41:31 ~3 min macos 📦zip
✔️ 5a8f7b3 #3 2025-07-14 18:42:56 ~4 min ios 📦zip
✔️ 5a8f7b3 #3 2025-07-14 18:43:09 ~4 min windows 📦zip
✔️ 5a8f7b3 #3 2025-07-14 18:43:25 ~5 min macos 📦zip
✔️ 5a8f7b3 #3 2025-07-14 18:45:00 ~6 min tests-rpc 📄log
✔️ 5a8f7b3 #3 2025-07-14 18:47:48 ~9 min linux 📦zip
✔️ e34e941 #4 2025-07-14 18:49:34 ~2 min android 📦aar
✖️ e34e941 #4 2025-07-14 18:49:36 ~2 min tests 📄log
✔️ e34e941 #4 2025-07-14 18:50:16 ~2 min linux 📦zip
✔️ e34e941 #4 2025-07-14 18:51:38 ~4 min macos 📦zip
✔️ e34e941 #4 2025-07-14 18:51:53 ~4 min ios 📦zip
✔️ e34e941 #4 2025-07-14 18:52:30 ~4 min windows 📦zip
✔️ e34e941 #4 2025-07-14 18:52:38 ~5 min macos 📦zip
✔️ e34e941 #4 2025-07-14 18:53:18 ~5 min tests-rpc 📄log
✔️ e34e941 #4 2025-07-14 18:55:24 ~7 min linux 📦zip
✔️ 630fd56 #5 2025-07-14 18:57:28 ~2 min android 📦aar
✔️ 630fd56 #5 2025-07-14 18:58:03 ~3 min linux 📦zip
✔️ 630fd56 #5 2025-07-14 18:58:58 ~4 min macos 📦zip
✔️ 630fd56 #5 2025-07-14 18:59:20 ~4 min ios 📦zip
✔️ 630fd56 #5 2025-07-14 18:59:55 ~4 min windows 📦zip
✔️ 630fd56 #5 2025-07-14 18:59:56 ~4 min macos 📦zip
✔️ 630fd56 #5 2025-07-14 19:01:01 ~6 min tests-rpc 📄log
✔️ 630fd56 #5 2025-07-14 19:03:21 ~7 min linux 📦zip
✖️ 630fd56 #5 2025-07-14 19:19:47 ~24 min tests 📄log
✔️ 24dec3d #6 2025-07-14 19:24:56 ~2 min android 📦aar
✔️ 24dec3d #6 2025-07-14 19:25:56 ~3 min linux 📦zip
✔️ 24dec3d #6 2025-07-14 19:26:21 ~4 min macos 📦zip
✔️ 24dec3d #6 2025-07-14 19:26:47 ~4 min ios 📦zip
✔️ 24dec3d #6 2025-07-14 19:27:10 ~4 min windows 📦zip
✔️ 24dec3d #6 2025-07-14 19:27:16 ~4 min macos 📦zip
✔️ 24dec3d #6 2025-07-14 19:28:18 ~5 min tests-rpc 📄log
✔️ 24dec3d #6 2025-07-14 19:30:39 ~8 min linux 📦zip
✖️ 24dec3d #6 2025-07-14 19:47:13 ~24 min tests 📄log
✔️ b594985 #7 2025-07-15 13:44:31 ~2 min android 📦aar
✔️ b594985 #7 2025-07-15 13:44:35 ~2 min linux 📦zip
✔️ b594985 #7 2025-07-15 13:47:10 ~5 min windows 📦zip
✔️ b594985 #7 2025-07-15 13:47:36 ~5 min macos 📦zip
✔️ b594985 #7 2025-07-15 13:47:52 ~6 min ios 📦zip
✖️ b594985 #7 2025-07-15 13:48:02 ~6 min tests-rpc 📄log
✔️ b594985 #7 2025-07-15 13:51:25 ~9 min macos 📦zip
✔️ b594985 #7 2025-07-15 13:52:26 ~10 min linux 📦zip
✔️ b594985 #7 2025-07-15 14:07:23 ~25 min tests 📄log
✔️ cc336a0 #8 2025-07-17 12:46:14 ~3 min linux 📦zip
✔️ cc336a0 #8 2025-07-17 12:46:15 ~3 min android 📦aar
✔️ cc336a0 #8 2025-07-17 12:47:34 ~4 min macos 📦zip
✔️ cc336a0 #8 2025-07-17 12:47:52 ~4 min windows 📦zip
✔️ cc336a0 #8 2025-07-17 12:48:18 ~5 min ios 📦zip
✔️ cc336a0 #8 2025-07-17 12:48:18 ~5 min macos 📦zip
✔️ cc336a0 #8 2025-07-17 12:52:20 ~9 min tests-rpc 📄log
✔️ cc336a0 #8 2025-07-17 12:53:21 ~10 min linux 📦zip
✔️ cc336a0 #8 2025-07-17 13:10:01 ~26 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 566df29 #9 2025-07-21 16:17:05 ~2 min tests 📄log
✔️ 566df29 #9 2025-07-21 16:17:52 ~2 min linux 📦zip
✔️ 566df29 #9 2025-07-21 16:17:53 ~3 min android 📦aar
✔️ 566df29 #9 2025-07-21 16:19:01 ~4 min macos 📦zip
✔️ 566df29 #9 2025-07-21 16:19:24 ~4 min ios 📦zip
✔️ 566df29 #9 2025-07-21 16:20:04 ~5 min macos 📦zip
✔️ 566df29 #9 2025-07-21 16:20:10 ~5 min windows 📦zip
✔️ 566df29 #9 2025-07-21 16:21:04 ~6 min tests-rpc 📄log
✔️ 566df29 #9 2025-07-21 16:24:52 ~9 min linux 📦zip
✔️ e7b2e23 #10 2025-07-21 16:20:48 ~2 min android 📦aar
✔️ e7b2e23 #10 2025-07-21 16:21:34 ~2 min linux 📦zip
✔️ e7b2e23 #10 2025-07-21 16:22:20 ~3 min macos 📦zip
✔️ e7b2e23 #10 2025-07-21 16:24:18 ~4 min ios 📦zip
✔️ e7b2e23 #10 2025-07-21 16:24:51 ~4 min windows 📦zip
✔️ e7b2e23 #10 2025-07-21 16:24:59 ~4 min macos 📦zip
✔️ e7b2e23 #10 2025-07-21 16:27:03 ~5 min tests-rpc 📄log
✔️ e7b2e23 #10 2025-07-21 16:28:40 ~9 min linux 📦zip
✔️ e7b2e23 #10 2025-07-21 16:43:03 ~24 min tests 📄log

Copy link
Contributor

@friofry friofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@dlipicar dlipicar force-pushed the chore/remove-deprecated-networks-connection-status branch 4 times, most recently from 24dec3d to b594985 Compare July 15, 2025 13:41
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 69.40299% with 41 lines in your changes missing coverage. Please review.

Project coverage is 60.25%. Comparing base (4960770) to head (e7b2e23).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
rpc/chain/client.go 45.45% 18 Missing ⚠️
services/wallet/api.go 33.33% 6 Missing ⚠️
services/wallet/transfer/controller.go 64.70% 5 Missing and 1 partial ⚠️
rpc/client.go 76.19% 2 Missing and 3 partials ⚠️
rpc/signals_transmitter.go 83.33% 2 Missing and 2 partials ⚠️
...let/router/pathprocessor/processor_bridge_celar.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6745      +/-   ##
===========================================
- Coverage    60.52%   60.25%   -0.28%     
===========================================
  Files          819      821       +2     
  Lines       100730   100703      -27     
===========================================
- Hits         60968    60677     -291     
- Misses       32139    32419     +280     
+ Partials      7623     7607      -16     
Flag Coverage Δ
functional 29.22% <63.43%> (-0.17%) ⬇️
unit 56.96% <55.97%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
healthmanager/aggregator/aggregator.go 100.00% <100.00%> (ø)
healthmanager/rpcstatus/provider_status.go 100.00% <100.00%> (ø)
node/get_status_node.go 71.00% <ø> (-0.18%) ⬇️
node/status_node_services.go 79.03% <100.00%> (ø)
protocol/messenger.go 63.88% <100.00%> (+0.21%) ⬆️
services/wallet/connection/status.go 88.57% <ø> (ø)
services/wallet/history/service.go 33.65% <100.00%> (ø)
services/wallet/reader.go 84.61% <100.00%> (ø)
services/wallet/router/router.go 62.13% <100.00%> (ø)
services/wallet/service.go 89.04% <100.00%> (-0.18%) ⬇️
... and 7 more

... and 56 files with indirect coverage changes

@dlipicar dlipicar force-pushed the chore/remove-deprecated-networks-connection-status branch from b594985 to cc336a0 Compare July 17, 2025 12:42
@dlipicar dlipicar force-pushed the chore/remove-deprecated-networks-connection-status branch from cc336a0 to 566df29 Compare July 21, 2025 16:14
@dlipicar dlipicar force-pushed the chore/remove-deprecated-networks-connection-status branch from 566df29 to e7b2e23 Compare July 21, 2025 16:18
@igor-sirotin igor-sirotin merged commit a46072c into develop Jul 21, 2025
23 checks passed
@igor-sirotin igor-sirotin deleted the chore/remove-deprecated-networks-connection-status branch July 21, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants