chore_: add emit-time timestamp to signal event #6743
+269
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6743 +/- ##
===========================================
+ Coverage 59.60% 59.67% +0.06%
===========================================
Files 818 818
Lines 100651 100652 +1
===========================================
+ Hits 59997 60060 +63
+ Misses 33092 33002 -90
- Partials 7562 7590 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fbarbu15
approved these changes
Jul 10, 2025
Required for DST chat protocol benchmarks. There might be delays between when a signal is emitted and when it is received by the test instance due to network conditions. Adding the timestamp at emit time addresses this.
osmaczko
force-pushed
the
chore/add-timestamp-to-events
branch
from
56ac4eb to
c2667bb
Compare
AlbertoSoutullo
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for DST chat protocol benchmarks. There might be delays between when a signal is emitted and when it is received by the test instance due to network conditions. Adding the timestamp at emit time addresses this.