Skip to content

fix_: Close sql statements #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Jul 3, 2025

Found a bunch of prepared statements that are not closed.

@alexjba alexjba requested review from alaibe, dlipicar and saledjenic July 3, 2025 12:10
@status-im-auto
Copy link
Member

status-im-auto commented Jul 3, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 1126c40 #1 2025-07-03 12:12:09 ~1 min tests 📄log
✔️ 1126c40 #1 2025-07-03 12:13:36 ~2 min android 📦aar
✔️ 1126c40 #1 2025-07-03 12:13:46 ~2 min linux 📦zip
✔️ 1126c40 #1 2025-07-03 12:13:56 ~3 min macos 📦zip
✔️ 1126c40 #1 2025-07-03 12:15:20 ~4 min macos 📦zip
✔️ 1126c40 #1 2025-07-03 12:16:34 ~5 min windows 📦zip
✔️ 1126c40 #1 2025-07-03 12:17:40 ~6 min tests-rpc 📄log
✔️ 1126c40 #1 2025-07-03 12:17:46 ~6 min ios 📦zip
✔️ 1126c40 #1 2025-07-03 12:20:31 ~9 min linux 📦zip
✔️ f067fa2 #2 2025-07-03 12:18:25 ~2 min android 📦aar
✔️ f067fa2 #2 2025-07-03 12:18:49 ~2 min linux 📦zip
✔️ f067fa2 #2 2025-07-03 12:19:38 ~3 min macos 📦zip
✔️ f067fa2 #2 2025-07-03 12:20:08 ~3 min macos 📦zip
✔️ f067fa2 #2 2025-07-03 12:21:56 ~5 min windows 📦zip
✖️ f067fa2 #2 2025-07-03 12:23:51 ~6 min tests-rpc 📄log
✔️ f067fa2 #2 2025-07-03 12:23:58 ~5 min ios 📦zip
✔️ f067fa2 #2 2025-07-03 12:30:28 ~9 min linux 📦zip
✔️ f067fa2 #3 2025-07-03 12:31:46 ~4 min tests-rpc 📄log
✖️ f067fa2 #2 2025-07-03 12:44:57 ~28 min tests 📄log

@alexjba alexjba force-pushed the fix/close-sql-statements branch from 1126c40 to f067fa2 Compare July 3, 2025 12:15
@alexjba alexjba changed the title fix: Close sql statements fix_: Close sql statements Jul 3, 2025
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 15.71429% with 59 lines in your changes missing coverage. Please review.

Project coverage is 28.77%. Comparing base (5a9fe3b) to head (f067fa2).

Files with missing lines Patch % Lines
services/wallet/collectibles/collection_data_db.go 0.00% 10 Missing ⚠️
protocol/message_persistence.go 33.33% 7 Missing and 1 partial ⚠️
...ervices/wallet/collectibles/collectible_data_db.go 0.00% 8 Missing ⚠️
services/wallet/transfer/database.go 12.50% 7 Missing ⚠️
services/wallet/community/database.go 0.00% 4 Missing ⚠️
...ces/wallet/transfer/block_ranges_sequential_dao.go 0.00% 4 Missing ⚠️
appmetrics/database.go 0.00% 3 Missing ⚠️
appdatabase/database.go 0.00% 2 Missing ⚠️
protocol/encryption/multidevice/persistence.go 60.00% 2 Missing ⚠️
protocol/persistence.go 0.00% 2 Missing ⚠️
... and 5 more

❌ Your patch check has failed because the patch coverage (15.71%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6727      +/-   ##
===========================================
- Coverage    28.85%   28.77%   -0.09%     
===========================================
  Files          791      791              
  Lines        98276    98342      +66     
===========================================
- Hits         28358    28294      -64     
- Misses       65522    65656     +134     
+ Partials      4396     4392       -4     
Flag Coverage Δ
functional 28.77% <15.71%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
multiaccounts/settings/database.go 62.90% <100.00%> (+0.06%) ⬆️
protocol/common/messaging_persistence.go 66.66% <100.00%> (-7.09%) ⬇️
services/wallet/currency/currency_db.go 71.05% <100.00%> (+0.78%) ⬆️
protocol/anonmetrics/server.go 0.00% <0.00%> (ø)
appdatabase/database.go 32.37% <0.00%> (-0.24%) ⬇️
protocol/encryption/multidevice/persistence.go 67.93% <60.00%> (-0.23%) ⬇️
protocol/persistence.go 55.87% <0.00%> (-0.11%) ⬇️
services/browsers/database.go 6.79% <0.00%> (-0.14%) ⬇️
services/wallet/collectibles/ownership_db.go 5.55% <0.00%> (-0.03%) ⬇️
services/wallet/token/token.go 25.60% <0.00%> (-0.12%) ⬇️
... and 8 more

... and 36 files with indirect coverage changes

Copy link
Contributor

@dlipicar dlipicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! We might be able to make this auto-checked by the Linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants