-
Notifications
You must be signed in to change notification settings - Fork 260
feat_: alchemy activity fetcher #6381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (150)
|
404f651
to
d4a116e
Compare
a036b84
to
a5f78c9
Compare
a5f78c9
to
6767578
Compare
6767578
to
f028630
Compare
7035466
to
c5f533e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding this, could we extend what we already have here https://github.com/status-im/status-go/blob/develop/services/wallet/bigint/big_int.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BigInt
encodes/decodes as a decimal value.
the new one uses a hex representation. It's needed specifically due to how Alchemy sends values in their response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this is a good location for this file? Maybe to move it to rpc/additional-providers/alchemy/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm well I wanted this to be a directory holding all proprietary activity providers. The fact that alchemy's uses the JSON-RPC protocol for requests/responses is just a coincidence
8d32fc1
to
4a61727
Compare
070140c
to
58bdf16
Compare
0fd68e3
to
66e8770
Compare
66e8770
to
adbc450
Compare
adbc450
to
097a15e
Compare
We require commits to follow the Conventional Commits, but with
|
Closed in favor of #6828 |
Part of status-im/status-desktop#17188