Skip to content

Conversation

dlipicar
Copy link
Contributor

@dlipicar dlipicar commented Feb 28, 2025

Part of status-im/status-desktop#17188

  • Add RPC Client API to get specific provider client
  • Implement Alchemy activity client

@status-im-auto
Copy link
Member

status-im-auto commented Feb 28, 2025

Jenkins Builds

Click to see older builds (150)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a036b84 #1 2025-02-28 21:02:18 ~3 min ios 📦zip
✔️ a036b84 #1 2025-02-28 21:02:20 ~3 min android 📦aar
✖️ a036b84 #1 2025-02-28 21:03:18 ~4 min tests 📄log
✔️ a036b84 #1 2025-02-28 21:03:48 ~4 min macos 📦zip
✔️ a036b84 #1 2025-02-28 21:04:37 ~5 min macos 📦zip
✔️ a036b84 #1 2025-02-28 21:05:27 ~6 min linux 📦zip
✔️ a036b84 #1 2025-02-28 21:05:38 ~6 min windows 📦zip
✔️ a036b84 #1 2025-02-28 21:19:29 ~20 min tests-rpc 📄log
✔️ a036b84 #2 2025-03-20 13:40:10 ~2 min android 📦aar
✔️ a036b84 #2 2025-03-20 13:40:22 ~3 min ios 📦zip
✖️ a036b84 #2 2025-03-20 13:41:35 ~4 min tests 📄log
✔️ a036b84 #2 2025-03-20 13:42:10 ~4 min macos 📦zip
✔️ a036b84 #2 2025-03-20 13:42:54 ~5 min macos 📦zip
✔️ a036b84 #2 2025-03-20 13:43:02 ~5 min linux 📦zip
✔️ a036b84 #2 2025-03-20 13:43:15 ~5 min windows 📦zip
✔️ a036b84 #2 2025-03-20 13:50:56 ~13 min tests-rpc 📄log
✔️ a5f78c9 #3 2025-03-20 13:53:32 ~3 min android 📦aar
✔️ a5f78c9 #3 2025-03-20 13:53:39 ~3 min ios 📦zip
✔️ a5f78c9 #3 2025-03-20 13:55:11 ~4 min macos 📦zip
✖️ a5f78c9 #3 2025-03-20 13:55:12 ~4 min tests 📄log
✔️ a5f78c9 #3 2025-03-20 13:55:23 ~4 min windows 📦zip
✔️ a5f78c9 #3 2025-03-20 13:56:02 ~5 min linux 📦zip
✔️ a5f78c9 #3 2025-03-20 13:56:32 ~5 min macos 📦zip
✔️ a5f78c9 #3 2025-03-20 14:20:56 ~29 min tests-rpc 📄log
✔️ 6767578 #4 2025-03-20 14:05:59 ~2 min android 📦aar
✖️ 6767578 #4 2025-03-20 14:06:00 ~2 min tests 📄log
✔️ 6767578 #4 2025-03-20 14:06:07 ~3 min ios 📦zip
✔️ 6767578 #4 2025-03-20 14:07:28 ~4 min windows 📦zip
✔️ 6767578 #4 2025-03-20 14:07:37 ~4 min macos 📦zip
✔️ 6767578 #4 2025-03-20 14:08:31 ~5 min linux 📦zip
✔️ 6767578 #4 2025-03-20 14:08:44 ~5 min macos 📦zip
✔️ f028630 #5 2025-03-20 14:12:34 ~3 min android 📦aar
✖️ f028630 #5 2025-03-20 14:12:35 ~2 min tests 📄log
✔️ f028630 #5 2025-03-20 14:12:43 ~3 min ios 📦zip
✔️ f028630 #5 2025-03-20 14:14:04 ~4 min windows 📦zip
✔️ f028630 #5 2025-03-20 14:14:13 ~4 min macos 📦zip
✔️ f028630 #5 2025-03-20 14:14:57 ~5 min linux 📦zip
✔️ f028630 #5 2025-03-20 14:15:20 ~5 min macos 📦zip
✔️ f028630 #4 2025-03-20 14:50:59 ~29 min tests-rpc 📄log
✔️ 7035466 #6 2025-03-20 15:06:13 ~3 min android 📦aar
✔️ 7035466 #6 2025-03-20 15:06:14 ~3 min ios 📦zip
✔️ 7035466 #6 2025-03-20 15:07:31 ~4 min windows 📦zip
✔️ 7035466 #6 2025-03-20 15:07:53 ~4 min macos 📦zip
✔️ 7035466 #6 2025-03-20 15:09:42 ~6 min macos 📦zip
✔️ 7035466 #6 2025-03-20 15:10:38 ~7 min linux 📦zip
✖️ 7035466 #6 2025-03-20 15:38:04 ~34 min tests 📄log
✖️ 7035466 #6 2025-03-20 16:14:22 ~28 min tests-rpc 📄log
✔️ c5f533e #7 2025-03-20 16:00:23 ~3 min ios 📦zip
✔️ c5f533e #7 2025-03-20 16:01:36 ~4 min windows 📦zip
✔️ c5f533e #7 2025-03-20 16:02:14 ~5 min macos 📦zip
✔️ c5f533e #7 2025-03-20 16:02:47 ~5 min macos 📦zip
✔️ c5f533e #7 2025-03-20 16:02:49 ~5 min android 📦aar
✔️ c5f533e #7 2025-03-20 16:07:30 ~10 min linux 📦zip
✔️ c5f533e #7 2025-03-20 16:36:46 ~39 min tests 📄log
✔️ c5f533e #7 2025-03-20 16:44:56 ~30 min tests-rpc 📄log
✔️ 42e87f0 #8 2025-03-26 20:57:01 ~3 min ios 📦zip
✔️ 42e87f0 #8 2025-03-26 20:57:14 ~3 min android 📦aar
✔️ 42e87f0 #8 2025-03-26 20:58:33 ~4 min macos 📦zip
✔️ 42e87f0 #8 2025-03-26 20:59:42 ~5 min macos 📦zip
✔️ 42e87f0 #8 2025-03-26 21:00:02 ~6 min linux 📦zip
✔️ 42e87f0 #8 2025-03-26 21:00:17 ~6 min windows 📦zip
✖️ 42e87f0 #8 2025-03-26 21:28:26 ~34 min tests 📄log
✔️ 8d32fc1 #9 2025-03-28 18:03:24 ~3 min android 📦aar
✔️ 8d32fc1 #9 2025-03-28 18:03:59 ~3 min ios 📦zip
✔️ 8d32fc1 #9 2025-03-28 18:04:16 ~3 min macos 📦zip
✔️ 8d32fc1 #9 2025-03-28 18:04:57 ~4 min windows 📦zip
✔️ 8d32fc1 #9 2025-03-28 18:05:55 ~5 min macos 📦zip
✔️ 8d32fc1 #9 2025-03-28 18:06:47 ~6 min linux 📦zip
✔️ 8d32fc1 #9 2025-03-28 18:08:42 ~8 min tests-rpc 📄log
✔️ 8d32fc1 #9 2025-03-28 18:36:05 ~35 min tests 📄log
✔️ 4a61727 #10 2025-03-31 13:38:33 ~2 min ios 📦zip
✔️ 4a61727 #10 2025-03-31 13:39:09 ~3 min android 📦aar
✔️ 4a61727 #10 2025-03-31 13:40:19 ~4 min windows 📦zip
✔️ 4a61727 #10 2025-03-31 13:41:09 ~5 min macos 📦zip
✔️ 4a61727 #10 2025-03-31 13:41:34 ~5 min macos 📦zip
✔️ 4a61727 #10 2025-03-31 13:42:01 ~6 min linux 📦zip
✔️ 4a61727 #10 2025-03-31 13:44:53 ~8 min tests-rpc 📄log
✔️ 4a61727 #10 2025-03-31 14:11:01 ~35 min tests 📄log
✔️ 94a6a39 #11 2025-04-09 13:21:25 ~3 min android 📦aar
✔️ 94a6a39 #11 2025-04-09 13:21:26 ~3 min ios 📦zip
✔️ 94a6a39 #11 2025-04-09 13:23:02 ~4 min macos 📦zip
✔️ 94a6a39 #11 2025-04-09 13:24:16 ~5 min macos 📦zip
✔️ 94a6a39 #11 2025-04-09 13:24:19 ~5 min linux 📦zip
✔️ 94a6a39 #11 2025-04-09 13:24:38 ~6 min windows 📦zip
✔️ 94a6a39 #11 2025-04-09 13:27:43 ~9 min tests-rpc 📄log
✔️ 94a6a39 #11 2025-04-09 13:53:26 ~34 min tests 📄log
✔️ 2a4ac9b #12 2025-04-10 19:32:20 ~2 min ios 📦zip
✔️ 2a4ac9b #12 2025-04-10 19:32:44 ~3 min android 📦aar
✔️ 2a4ac9b #12 2025-04-10 19:33:28 ~3 min macos 📦zip
✔️ 2a4ac9b #12 2025-04-10 19:35:08 ~5 min macos 📦zip
✔️ 2a4ac9b #12 2025-04-10 19:35:18 ~5 min windows 📦zip
✔️ 2a4ac9b #12 2025-04-10 19:36:04 ~6 min linux 📦zip
✔️ 2a4ac9b #12 2025-04-10 19:38:41 ~9 min tests-rpc 📄log
✔️ 2a4ac9b #12 2025-04-10 20:04:01 ~34 min tests 📄log
✔️ 070140c #13 2025-04-11 20:25:25 ~3 min ios 📦zip
✔️ 070140c #13 2025-04-11 20:25:35 ~3 min android 📦aar
✔️ 58bdf16 #13 2025-04-11 20:27:33 ~5 min windows 📦zip
✔️ 58bdf16 #14 2025-04-11 20:28:13 ~5 min macos 📦zip
✔️ 58bdf16 #14 2025-04-11 20:28:23 ~2 min ios 📦zip
✔️ 58bdf16 #14 2025-04-11 20:28:29 ~5 min macos 📦zip
✔️ 58bdf16 #14 2025-04-11 20:29:24 ~3 min android 📦aar
✔️ 58bdf16 #14 2025-04-11 20:30:01 ~7 min linux 📦zip
✔️ 58bdf16 #14 2025-04-11 20:32:05 ~9 min tests-rpc 📄log
✔️ 58bdf16 #14 2025-04-11 20:32:14 ~4 min windows 📦zip
✔️ 58bdf16 #14 2025-04-11 20:57:31 ~34 min tests 📄log
✖️ 23f9d40 #15 2025-06-24 17:53:18 ~1 min tests 📄log
✔️ 23f9d40 #15 2025-06-24 17:55:09 ~3 min android 📦aar
✔️ 23f9d40 #15 2025-06-24 17:55:16 ~3 min macos 📦zip
✔️ 23f9d40 #15 2025-06-24 17:55:46 ~3 min linux 📦zip
✔️ 23f9d40 #15 2025-06-24 17:57:46 ~5 min ios 📦zip
✔️ 23f9d40 #15 2025-06-24 17:58:26 ~6 min windows 📦zip
✔️ 23f9d40 #15 2025-06-24 17:58:59 ~6 min tests-rpc 📄log
✔️ 23f9d40 #15 2025-06-24 18:03:33 ~11 min macos 📦zip
✔️ 23f9d40 #1 2025-06-24 18:04:30 ~12 min linux 📦zip
✖️ 191954c #16 2025-06-24 18:48:50 ~1 min tests 📄log
✔️ 191954c #16 2025-06-24 18:50:26 ~2 min macos 📦zip
✔️ 191954c #16 2025-06-24 18:51:03 ~3 min android 📦aar
✔️ 191954c #16 2025-06-24 18:51:24 ~3 min macos 📦zip
✔️ 191954c #16 2025-06-24 18:51:33 ~4 min linux 📦zip
✔️ 191954c #16 2025-06-24 18:53:05 ~5 min ios 📦zip
✔️ 191954c #16 2025-06-24 18:53:22 ~5 min tests-rpc 📄log
✔️ 191954c #16 2025-06-24 18:53:48 ~6 min windows 📦zip
✔️ 191954c #2 2025-06-24 19:00:29 ~13 min linux 📦zip
✖️ 0fd68e3 #17 2025-06-24 22:14:02 ~2 min tests 📄log
✔️ 0fd68e3 #17 2025-06-24 22:14:31 ~3 min macos 📦zip
✔️ 0fd68e3 #17 2025-06-24 22:15:16 ~3 min android 📦aar
✔️ 0fd68e3 #17 2025-06-24 22:15:28 ~3 min macos 📦zip
✔️ 0fd68e3 #17 2025-06-24 22:15:30 ~4 min linux 📦zip
✔️ 0fd68e3 #17 2025-06-24 22:17:10 ~5 min tests-rpc 📄log
✔️ 0fd68e3 #17 2025-06-24 22:17:32 ~5 min windows 📦zip
✔️ 0fd68e3 #17 2025-06-24 22:19:19 ~7 min ios 📦zip
✔️ 0fd68e3 #3 2025-06-24 22:21:39 ~10 min linux 📦zip
✖️ 66e8770 #18 2025-06-25 02:34:33 ~2 min tests 📄log
✔️ 66e8770 #18 2025-06-25 02:35:02 ~3 min macos 📦zip
✔️ 66e8770 #18 2025-06-25 02:35:08 ~3 min android 📦aar
✔️ 66e8770 #18 2025-06-25 02:35:49 ~3 min linux 📦zip
✔️ 66e8770 #18 2025-06-25 02:35:57 ~3 min macos 📦zip
✔️ 66e8770 #18 2025-06-25 02:37:43 ~5 min ios 📦zip
✔️ 66e8770 #18 2025-06-25 02:38:12 ~6 min tests-rpc 📄log
✔️ 66e8770 #18 2025-06-25 02:38:24 ~6 min windows 📦zip
✔️ 66e8770 #4 2025-06-25 02:41:37 ~9 min linux 📦zip
✖️ adbc450 #19 2025-06-26 17:30:52 ~2 min tests 📄log
✔️ adbc450 #19 2025-06-26 17:31:28 ~3 min macos 📦zip
✔️ adbc450 #19 2025-06-26 17:31:45 ~3 min android 📦aar
✔️ adbc450 #19 2025-06-26 17:32:26 ~3 min macos 📦zip
✔️ adbc450 #19 2025-06-26 17:32:49 ~4 min linux 📦zip
✔️ adbc450 #19 2025-06-26 17:33:37 ~5 min windows 📦zip
✔️ adbc450 #19 2025-06-26 17:34:25 ~5 min tests-rpc 📄log
✔️ adbc450 #19 2025-06-26 17:35:23 ~7 min ios 📦zip
✔️ adbc450 #5 2025-06-26 17:43:14 ~14 min linux 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 097a15e #20 2025-06-27 17:39:36 ~2 min macos 📦zip
✔️ 097a15e #20 2025-06-27 17:39:42 ~3 min android 📦aar
✖️ 097a15e #20 2025-06-27 17:40:28 ~3 min tests 📄log
✔️ 097a15e #20 2025-06-27 17:40:50 ~4 min linux 📦zip
✔️ 097a15e #20 2025-06-27 17:40:57 ~4 min macos 📦zip
✔️ 097a15e #20 2025-06-27 17:41:39 ~4 min windows 📦zip
✔️ 097a15e #20 2025-06-27 17:41:58 ~5 min ios 📦zip
✔️ 097a15e #20 2025-06-27 17:43:19 ~6 min tests-rpc 📄log
✔️ 097a15e #6 2025-06-27 17:47:25 ~10 min linux 📦zip
53eda08 #21 2025-06-30 13:50:42 ~1 min linux 📄log
53eda08 #7 2025-06-30 13:50:42 ~1 min linux 📄log
✖️ 53eda08 #21 2025-06-30 13:50:51 ~1 min tests 📄log
53eda08 #21 2025-06-30 13:51:09 ~1 min macos 📄log
53eda08 #21 2025-06-30 13:51:48 ~2 min android 📄log
✖️ 53eda08 #21 2025-06-30 13:52:07 ~2 min tests-rpc 📄log
53eda08 #21 2025-06-30 13:52:40 ~3 min windows 📄log
53eda08 #21 2025-06-30 13:52:48 ~3 min ios 📄log
53eda08 #21 2025-06-30 15:18:39 ~1 hr 29 min macos 📄log

@dlipicar dlipicar force-pushed the chore/cleanup-deprecated-activity-code branch 10 times, most recently from 404f651 to d4a116e Compare March 19, 2025 21:34
Base automatically changed from chore/cleanup-deprecated-activity-code to develop March 20, 2025 13:36
@alaibe alaibe requested a review from friofry as a code owner March 20, 2025 13:36
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch from a036b84 to a5f78c9 Compare March 20, 2025 13:50
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch from a5f78c9 to 6767578 Compare March 20, 2025 14:02
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch from 6767578 to f028630 Compare March 20, 2025 14:09
@dlipicar dlipicar requested review from alaibe, saledjenic and a team March 20, 2025 15:07
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch from 7035466 to c5f533e Compare March 20, 2025 15:56
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 51.62095% with 194 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (43a7d57) to head (58bdf16).

Files with missing lines Patch % Lines
...vices/wallet/thirdparty/activity/alchemy/client.go 0.00% 106 Missing ⚠️
services/wallet/activityfetcher/persistence.go 72.17% 17 Missing and 15 partials ⚠️
...rvices/wallet/thirdparty/activity/alchemy/types.go 77.02% 13 Missing and 4 partials ⚠️
rpc/provider_chain_client_getter.go 0.00% 6 Missing ⚠️
rpc/chain/client.go 0.00% 5 Missing ⚠️
rpc/client.go 0.00% 5 Missing ⚠️
services/wallet/bigint/var_hex_big_int.go 55.55% 2 Missing and 2 partials ⚠️
services/wallet/thirdparty/activity_types.go 0.00% 4 Missing ⚠️
rpc/network/networksevent/watcher.go 0.00% 2 Missing and 1 partial ⚠️
services/accounts/accountsevent/watcher.go 0.00% 2 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6381      +/-   ##
===========================================
- Coverage    60.40%   60.36%   -0.05%     
===========================================
  Files          850      856       +6     
  Lines       104972   105323     +351     
===========================================
+ Hits         63409    63574     +165     
- Misses       33924    34082     +158     
- Partials      7639     7667      +28     
Flag Coverage Δ
functional 25.16% <56.60%> (-0.04%) ⬇️
unit 58.26% <51.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/default_networks.go 99.33% <100.00%> (+0.02%) ⬆️
services/wallet/thirdparty/collectible_types.go 82.55% <ø> (ø)
sqlite/fields.go 80.39% <100.00%> (+0.80%) ⬆️
rpc/network/networksevent/watcher.go 57.89% <0.00%> (-4.97%) ⬇️
services/accounts/accountsevent/watcher.go 74.41% <0.00%> (-5.59%) ⬇️
services/accounts/settingsevent/watcher.go 77.77% <0.00%> (-7.08%) ⬇️
services/wallet/history/transfers_watcher.go 63.88% <0.00%> (-5.81%) ⬇️
services/wallet/walletevent/watcher.go 75.75% <0.00%> (-7.58%) ⬇️
services/wallet/bigint/var_hex_big_int.go 55.55% <55.55%> (ø)
services/wallet/thirdparty/activity_types.go 0.00% <0.00%> (ø)
... and 6 more

... and 29 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigInt encodes/decodes as a decimal value.
the new one uses a hex representation. It's needed specifically due to how Alchemy sends values in their response.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this is a good location for this file? Maybe to move it to rpc/additional-providers/alchemy/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm well I wanted this to be a directory holding all proprietary activity providers. The fact that alchemy's uses the JSON-RPC protocol for requests/responses is just a coincidence

@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch 3 times, most recently from 8d32fc1 to 4a61727 Compare March 31, 2025 13:35
saledjenic
saledjenic previously approved these changes Apr 1, 2025
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch 3 times, most recently from 070140c to 58bdf16 Compare April 11, 2025 20:22
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch 4 times, most recently from 0fd68e3 to 66e8770 Compare June 25, 2025 02:31
@dlipicar dlipicar marked this pull request as draft June 25, 2025 03:44
@dlipicar dlipicar requested review from saledjenic and friofry and removed request for alaibe, saledjenic and friofry June 26, 2025 17:25
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch from 66e8770 to adbc450 Compare June 26, 2025 17:28
@dlipicar dlipicar force-pushed the feat/alchemy-activity-fetcher branch from adbc450 to 097a15e Compare June 27, 2025 17:36
Copy link

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

WIP: fetcher rework

@dlipicar
Copy link
Contributor Author

Closed in favor of #6828

@dlipicar dlipicar closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants