Skip to content

Fix Gloas clearance#8091

Open
ahshum wants to merge 14 commits intounstablefrom
sam/Bmy
Open

Fix Gloas clearance#8091
ahshum wants to merge 14 commits intounstablefrom
sam/Bmy

Conversation

@ahshum
Copy link
Contributor

@ahshum ahshum commented Mar 16, 2026

Summary

  • check parent envelope before adding block to clearance state.
    • same check in block_processor in order to mark envelope as missing with new VerifierError
  • updateState() when adding envelope to clearance state.
    • check slot and root of envelope with state instead of block
  • Modify addPayload() to handle MissingParent error.
  • FcU correctly

@github-actions
Copy link

github-actions bot commented Mar 16, 2026

Unit Test Results

       12 files  ±0    2 488 suites  ±0   48m 45s ⏱️ - 10m 38s
12 978 tests ±0  12 431 ✔️ ±0  547 💤 ±0  0 ±0 
65 612 runs  ±0  64 902 ✔️ ±0  710 💤 ±0  0 ±0 

Results for commit ca11695. ± Comparison against base commit b10e378.

♻️ This comment has been updated with latest results.

ahshum added a commit that referenced this pull request Mar 18, 2026
@tersec
Copy link
Contributor

tersec commented Mar 19, 2026

Merge conflict with beacon_chain/gossip_processing/block_processor.nim.

@ahshum ahshum marked this pull request as draft March 19, 2026 17:22
@ahshum ahshum marked this pull request as ready for review March 20, 2026 13:06
@ahshum
Copy link
Contributor Author

ahshum commented Mar 20, 2026

Taking out e79a45d as it would be replaced by a new VerifierError and handler. And it seems it breaks block_sims.

@tersec
Copy link
Contributor

tersec commented Mar 24, 2026

2026-03-24T15:55:17.8310404Z Block processor [Preset: mainnet] ........F.F. (14.1s)
2026-03-24T15:55:17.8311524Z =======================================================================
2026-03-24T15:55:17.8321162Z   /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/build/all_tests 'Block processor [Preset: mainnet]::Gloas block pops pre-arrived envelope from quarantine [Preset: mainnet]'
2026-03-24T15:55:17.8322783Z -----------------------------------------------------------------------
2026-03-24T15:55:17.8324360Z     /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/tests/test_block_processor.nim(470, 32): Check failed: engineBlock.blck.root notin envelopeQuarantine[].getMissing()
2026-03-24T15:55:17.8325666Z 
2026-03-24T15:55:17.8326433Z   [FAILED ] (  1.19s) Gloas block pops pre-arrived envelope from quarantine [Preset: mainnet]
2026-03-24T15:55:17.8327083Z 
2026-03-24T15:55:17.8327286Z ================================================================
2026-03-24T15:55:17.8328784Z   /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/build/all_tests 'Block processor [Preset: mainnet]::Gloas reverse order blocks with missing parent [Preset: mainnet]'
2026-03-24T15:55:17.8330811Z ----------------------------------------------------------------
2026-03-24T15:55:17.8332133Z     /github-runner/github-runner-node-02/workspace/nimbus-eth2/nimbus-eth2/tests/test_block_processor.nim(544, 31): Check failed: dag.containsForkBlock(b2.root)
2026-03-24T15:55:17.8333225Z 
2026-03-24T15:55:17.8333773Z   [FAILED ] (  1.21s) Gloas reverse order blocks with missing parent [Preset: mainnet]
2026-03-24T15:55:17.8334377Z 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants