Skip to content

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Sep 1, 2025

https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlock is deprecated with support disappearing likely across much of the ecosystem sometime after Fusaka forks on mainnet.

https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlockV2 supports at least all the forks the non-V2 version does, even if one wants to use the VC in a pre-Electra network. Furthermore, none of the officially supported networks of Nimbus even involve producing pre-Pectra blocks anymore, so for those networks (Ethereum mainnet, Hoodi, Holesky, Sepolia, Gnosis mainnet, Chiado) it's already unused code.

One maintenance issue is that each time a hardfork is added, it adds 3 different places which have to be adjusted, which is why I'm looking at this while adding Glamsterdam.

@tersec tersec requested a review from cheatfate September 1, 2025 02:44
Copy link

github-actions bot commented Sep 1, 2025

Unit Test Results

       15 files  ±0    2 660 suites  ±0   1h 27m 33s ⏱️ - 1m 53s
10 794 tests ±0  10 232 ✔️ ±0  562 💤 ±0  0 ±0 
66 506 runs  ±0  65 714 ✔️ ±0  792 💤 ±0  0 ±0 

Results for commit 17b1e60. ± Comparison against base commit 9e906b1.

@tersec tersec merged commit 7014120 into unstable Sep 2, 2025
12 checks passed
@tersec tersec deleted the p9j branch September 2, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants