Load model from config #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would probably be better to update the UpdateScript for this migration to not publish if the site repository is not eloquent: https://github.com/statamic/eloquent-driver/blob/4.x/src/Updates/AddOrderToSitesTable.php |
Contributor
Author
|
Agreed, changed it around to check for the config there instead! |
Contributor
|
Looks good to me, thanks for making the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sites driver is kept on file and this migration gets added to your project the following error occurs when running the migrations.
This is correct because the model is only binded on the app if the sites driver is configured as eloquent.
I changed the migration to use the model from the config instead, this way it's always available.