Skip to content

Github Actions updates #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Conversation

james-s-w-clark
Copy link
Contributor

@james-s-w-clark james-s-w-clark commented Jun 23, 2022

I like this project, and saw you use Github Actions.
Saw there's a couple things that could be simplier/more efficient, so thought I'd raise a PR :)

I tried testing locally with act but it's getting stuck downloading apt updates, so I thought I'd raise a PR.

Approval is needed to allow the Github Action workflow, thanks 👍

@james-s-w-clark james-s-w-clark changed the title Actions update Github Actions updates Jun 23, 2022
Copy link
Member

@acabal acabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to specify a version of Ubuntu because the SE server runs on a specific version and we have to make sure the tools work on that version. Can you undo the move to ubuntu-latest?

@@ -11,17 +11,11 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.x-dev'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove -dev from here, but in a ad722fc we specified 3.x-dev?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried 3.x-dev as https://github.com/actions/setup-python#available-versions-of-python says that it'd get the latest patch version thanks to dev. It didn't exist in the manifest when I tried running the action locally with act though:

::error::Version 3.x-dev with arch x64 not found%0AThe list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

3.x seems to be the most common version I see for Github Actions, e.g. in the first basic snippet here https://github.com/actions/setup-python#usage.

One strange thing: https://github.com/actions/setup-python/releases/tag/v4.0.0 has a commit to fix the 3.x-dev syntax. I think the bug is unrelated to not parsing the version and finding best patch version in the manifest though 🤔

Copy link
Contributor Author

@james-s-w-clark james-s-w-clark Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.11-dev works - it finds 3.11.0-beta.3

3.x gets python-3.10.5-linux-20.04-x64.tar.gz

Are you happy with 3.x (auto incrementing, and more stable), or prefer a fixed version with dev (bleeding edge for a short time, more maintenance, less stable)?

@james-s-w-clark james-s-w-clark marked this pull request as ready for review June 24, 2022 00:02
@acabal acabal merged commit c9fd484 into standardebooks:master Jun 24, 2022
@acabal
Copy link
Member

acabal commented Jun 24, 2022

OK, this looks good, thanks! Let's stick with the more stable version of Python.

@james-s-w-clark james-s-w-clark deleted the actions-update branch June 24, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants