Include function suffixes when looking for "Did you mean" suggestions #1401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Since #1024, unknown identifier related errors give a similar identifier as a suggestion but the algorithm only considered typos involving at most three letters. Another likely error is omitting the distribution suffix from a function name:
https://discourse.mc-stan.org/t/how-to-interpret-a-returning-function-was-expected-but-an-undeclared-identifier-was-supplied/34078
Release notes
When encountering an unknown identifier that matches a known suffixed function without its suffix, add the known function name to the error message.
Copyright and Licensing
Copyright holder: Niko Huurre
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)