Skip to content

Conversation

@WardBrian
Copy link
Member

This would be useless code, so it is relatively benign, but it still shouldn't cause a compile failure.

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Fixed an issue where multiple reject statements could cause the C++ compiler to fail

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian WardBrian requested a review from nhuurre January 31, 2024 14:41
@codecov
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f2dbe7) 89.88% compared to head (771f372) 89.88%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          63       63           
  Lines       10505    10506    +1     
=======================================
+ Hits         9442     9443    +1     
  Misses       1063     1063           
Files Coverage Δ
src/frontend/Typechecker.ml 91.97% <100.00%> (ø)
src/stan_math_backend/Lower_stmt.ml 95.38% <100.00%> (+0.02%) ⬆️

Copy link
Collaborator

@nhuurre nhuurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WardBrian WardBrian merged commit 2015f5b into master Feb 2, 2024
@WardBrian WardBrian deleted the fix/double-reject-cpp branch February 2, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants