fix(mcp): artifact large tool outputs in proxy#750
Merged
Conversation
kajogo777
approved these changes
Jun 8, 2026
| } | ||
|
|
||
| let flattened_text = text_blocks.join("\n"); | ||
| let file_prefix = format!("mcp-tool-output.{}.{}", client_name, tool_name); |
Member
There was a problem hiding this comment.
we don't need mcp-tool-output prefix, we also proxy internal tools, this might give the model ideas or confuse it, if it has internal knowledge about what MCP means, we can just leave it as tool-output
Rename large-output artifact prefix from mcp-tool-output to tool-output so it doesn't leak MCP protocol semantics to the model (we also proxy internal tools). Keeps a neutral, self-describing prefix so artifacts stay greppable in the shared session store. Addresses review feedback on #750.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move large-output artifacting to the MCP proxy boundary so final tool results are compacted before reaching downstream clients while preserving raw tool-server output internally.
Related Issues
None
Changes Made
Testing
Screenshots (if applicable)
N/A
Breaking Changes
None