[ZH CVVC] Automatically add syllable ending if present (if next neighbor is null) #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically adds a syllable ending to a note if the next neighbor is null (and if it exists in the oto). This function was added due to the existence of closed syllables and falling diphthongs in Chinese (unlike Japanese, where this can be optional). Currently, this has to be done manually on a separate note, which can be a relatively easy oversight.
Placing the ending on a separate note is still possible, if preferred. It also should not conflict with any end breaths etc.
Feedback is welcome.