Skip to content

Conversation

@lottev1991
Copy link
Contributor

@lottev1991 lottev1991 commented Nov 22, 2023

This PR makes it so that aliases can now also be extended across different subbanks in syllable-based phonemizers. Note that the option to restrict it to only the same subbank has not been removed; I've simply made it so that it will be up to the phonemizer developers to decide.

The reason I am making this PR is because the current spec can cause issues when extending diphthongs in certain languages (including English) across different pitches and/or voice colors.

In order to re-implement the previous spec into a phonemizer, the code should look something like this:

if (CanMakeAliasExtension(syllable) && AreTonesFromTheSameSubbank(syllable.tone, syllable.vowelTone))

or, in negative form:

if (!CanMakeAliasExtension(syllable) || !AreTonesFromTheSameSubbank(syllable.tone, syllable.vowelTone))

@lottev1991 lottev1991 changed the title [SyllableBasedPhonemizer API] Make alias extension restricted to same subbank optional [SyllableBasedPhonemizer API] Make alias extension restriction to same subbank optional Nov 22, 2023
@stakira stakira merged commit c08b80c into stakira:master Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants