Fix TextBox font #906
Merged
Fix TextBox font #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakira
reviewed
Nov 14, 2023
OpenUtau/Styles/Styles.axaml
Outdated
| <Setter Property="Margin" Value="0,0,0,4"/> | ||
| <Setter Property="FontSize" Value="12"/> | ||
| <Setter Property="FontFamily" Value="{DynamicResource ui.textbox.fontfamily}"/> | ||
| <Setter Property="FontFamily" Value="{DynamicResource ui.fontfamily}"/> |
Owner
There was a problem hiding this comment.
These was for working around Avalonia 10 could not handle CJK font fallback in text boxes. You can simply delete this line and delete ui.textbox.fontfamily from Strings.axaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font used for the text boxes is a bit hard to read in Japanese, so changed to the same font as the text and labels.
It may depend on the environment, but it will not have any adverse effect.
This is largely a personal preference, so please merge if necessary.