Skip to content

Check if miniaudio is not paused before resetting currentTimeMs. #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stakira merged 1 commit into from
Nov 10, 2025
Merged

Check if miniaudio is not paused before resetting currentTimeMs. #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion OpenUtau.Core/Audio/MiniAudioOutput.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ public void Play() {
if (PlaybackState != PlaybackState.Playing) {
CheckError(ou_audio_device_start(nativeContext));
}
if (PlaybackState != PlaybackState.Paused) {
currentTimeMs = 0;
}
PlaybackState = PlaybackState.Playing;
currentTimeMs = 0;
eof = false;
}

Expand Down
2 changes: 0 additions & 2 deletions OpenUtau.Core/PlaybackManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,6 @@ public void PlayOrPause(int tick = -1, int endTick = -1, int trackNo = -1) {

public void Play(UProject project, int tick, int endTick = -1, int trackNo = -1) {
if (AudioOutput.PlaybackState == PlaybackState.Paused) {
startMs = project.timeAxis.TickPosToMsPos(tick);
masterMix.Waited = 0;
PlayingMaster = true;
AudioOutput.Play();
return;
Expand Down
2 changes: 1 addition & 1 deletion OpenUtau.Core/SignalChain/MasterAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class MasterAdapter : ISampleProvider {
private int position;

public WaveFormat WaveFormat => waveFormat;
public int Waited { get; set; }
public int Waited { get; private set; }
public bool IsWaiting { get; private set; }
public MasterAdapter(ISignalSource source) {
waveFormat = WaveFormat.CreateIeeeFloatWaveFormat(44100, 2);
Expand Down
Loading