Skip to content

Conversation

@stakira
Copy link
Owner

@stakira stakira commented Sep 13, 2025

Reverts #1577

Copilot AI review requested due to automatic review settings September 13, 2025 17:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous fix related to legacy plugin output handling. The revert undoes changes that were made to improve legacy plugin output formatting, returning the code to its previous state.

  • Removes automatic envelope data writing for legacy plugin notes
  • Reverts note numbering system back to using count-based indexing instead of sequence position
  • Updates test expectations to match the reverted behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
OpenUtau.Test/Classic/PluginRunnerTest.cs Updates test expectations to remove envelope data and revert note numbering
OpenUtau.Core/Classic/UstNote.cs Removes automatic envelope writing for plugin output
OpenUtau.Core/Classic/Ust.cs Reverts note numbering from sequence-based to count-based indexing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stakira stakira merged commit a60ca58 into master Sep 13, 2025
6 checks passed
@stakira stakira deleted the revert-1577-master branch November 26, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants