Fix note editing tool toggle button behavior #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed a minor GUI issue when clicking on the tool icon that is already selected, it will lose its highlighting (which I believe is not the intended behavior).
Details
Let's say the pencil tool is currently selected.
You can reproduce this issue by simply clicking on the pencil tool.
Now, the tool icon is no longer highlighted/shadowed. Note that this does not affect the function of the mouse curser, meaning you're still using the pencil tool. This will possibly appear confusing for users to know what tool they're using.
This problem is fixed, making the tool icon keep its highlighting/shadowing after being clicked while already selected.