Fix tone generator crackling #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also lays some groundwork for MIDI recording
stakira
added a commit
that referenced
this pull request
Nov 7, 2025
keirokeer
added a commit
to keirokeer/OpenUtau-DiffSinger-Lunai
that referenced
this pull request
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the crackling sound sometimes heard when entering notes on the piano roll by implementing note enveloping (Attack and release) in the tone synth.
Video after fix:
2025-08-01.15-18-42.mp4
Video before fix (Volume up):
2025-08-01.17-50-23.mp4
I also did some light code restructuring to lay the groundwork for the tone synth being able to play during project playback, which is necessary for a future PR with MIDI recording.