Skip to content

Conversation

@IsE333
Copy link
Contributor

@IsE333 IsE333 commented May 9, 2025

  • Added TurkishCVVCPhonemizer in OpenUtau.Plugin.Builtin/TurkishCVVCPhonemizer.cs. This class includes logic for processing Turkish CVVC phonemes, handling consonant-vowel transitions, and generating phoneme results based on note attributes.

  • Also added the Turkish language (languages.tr) in OpenUtau/Strings/Strings.axaml for the phonemizer language list.

Copilot AI review requested due to automatic review settings May 9, 2025 12:46
@IsE333 IsE333 requested a review from oxygen-dioxide as a code owner May 9, 2025 12:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Turkish CVVC phonemizer for processing Turkish phonemes along with adding Turkish language support.

  • Implements TurkishCVVCPhonemizer with logic for handling consonant-vowel transitions.
  • Adds a Turkish language string for UI localization in Strings.axaml.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
OpenUtau/Strings/Strings.axaml Added Turkish language string entry
OpenUtau.Plugin.Builtin/TurkishCVVCPhonemizer.cs Introduced TurkishCVVCPhonemizer with CVVC phoneme processing logic
Comments suppressed due to low confidence (2)

OpenUtau.Plugin.Builtin/TurkishCVVCPhonemizer.cs:8

  • The language code in the phonemizer attribute is set to "TR" while the language key in the strings file is "tr". Consider aligning the casing to avoid potential case-sensitivity issues.
[Phonemizer("Turkish CVVC Phonemizer", "TR CVVC", "ise", language: "TR")]

OpenUtau.Plugin.Builtin/TurkishCVVCPhonemizer.cs:285

  • The variable 'timeAxis' is used without an explicit declaration or context in this diff. Ensure that 'timeAxis' is properly defined or inherited to avoid compilation errors.
lastLengthFromOto = timeAxis.MsPosToTickPos(oto0.Preutter - oto0.Overlap);

@stakira stakira merged commit 21c4693 into stakira:master May 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants