Skip to content

Conversation

@oxygen-dioxide
Copy link
Collaborator

image

@stakira stakira merged commit c181994 into stakira:master Feb 24, 2025
3 checks passed
@oxygen-dioxide
Copy link
Collaborator Author

oxygen-dioxide commented Feb 24, 2025

@RedBlackAka Do you mean that you don't like this feature?
My idea is: voicebank developer can declare a recommended phonemizer. If the user switched to another phonemizer accidentally or for certain reason, and want to go back to the original phonemizer, before this PR, they have to find the phonemizer manually in the list, or open character.yaml by hand to see what's the original phonemizer. After this PR, they will be able to switch back to the phonemizer declared in the voicebank quickly.
If you don't like it, we can add a preference item.

@RedBlackAka
Copy link
Contributor

It is fine, initially though it would guess a phonemizer, but mixed it up with one of the suggested ideas. I wanted to only have it shown if one was defined, which seems to be the case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants