Add checks for phoneme definitions in dsdict.yaml #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some inputs of DiffSinger depend on whether the phones are vowels. However,
G2pDictionary.IsVowel()returnsfalseif the phoneme symbol is not found in the dictionary (mostly dsdict.yaml). The rendering continues because the phoneme exists in the phoneme list (mostly phonemes.txt), but produces wrong results because the types of the phonemes are misconfigured. Many people missed some phonemes in their dictionary and had trouble debugging.This PR adds some checks so that all phonemes should be defined in dictionary if the inputs depend on the phoneme types. If not, OpenUTAU shows an explicit error message.