Skip to content

Conversation

@sdercolin
Copy link
Contributor

@sdercolin sdercolin commented Jan 10, 2024

Implement VB checking of duplicates like a.wav and A.wav which would not work on case-insensitive OS.

Also removes some conditions on the current OS, so we apply all checks on all platforms, without knowing whether the current OS is case-sensitive or not.

@sdercolin sdercolin force-pushed the feature/unix-vb-check branch from 9d79c43 to 9615d9a Compare January 10, 2024 11:26
@sdercolin sdercolin changed the title Add UnixCaseCheck in voice bank check Add case check on case-insensitive systems in voicebank check Jan 10, 2024
@stakira
Copy link
Owner

stakira commented Jan 25, 2024

Could you please unify the check despite OS to ensure:

  1. Case matches.
  2. No files that only differ in case. We can do so for all files, not just wavs.

The check doesn't block normal uses. So let's simply be strict, so that checked VB works everywhere.

@sdercolin
Copy link
Contributor Author

@stakira Please check again!
cc @oxygen-dioxide

@stakira stakira merged commit e39c3b3 into stakira:master Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants