Skip to content

Conversation

@oxygen-dioxide
Copy link
Collaborator

@oxygen-dioxide oxygen-dioxide commented Jan 2, 2024

This PR adds an IsGlide method to IG2p that tells whether a phoneme is a semivowel or liquid sound, like y, w, l, r in English.

In "Consonant - Glide - Vowel" syllables such as "grass", glide phoneme should be put after the start position of the note.

I've tested some external dll phonemizers released before this change. They work successfully as before.

@oxygen-dioxide
Copy link
Collaborator Author

oxygen-dioxide commented Jan 2, 2024

TODO in the future:

  • Add glide support for Machine Learning phonemizers
  • Refactor G2pPack to make it fully portable. (Currently grapheme and phoneme definitions are hard coded in C# which makes it impossible to load external G2pPacks)

@oxygen-dioxide oxygen-dioxide changed the title g2p: add IsGlide method G2p: add IsGlide method; EN ARPA: support glide phonemes. Jan 2, 2024
@oxygen-dioxide oxygen-dioxide marked this pull request as ready for review January 2, 2024 05:26
@oxygen-dioxide
Copy link
Collaborator Author

image

@stakira stakira merged commit 236f747 into stakira:master Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants