-
Notifications
You must be signed in to change notification settings - Fork 697
Clarity-wasm: fix for clarity-wasm issue 700 #6345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarity-wasm: fix for clarity-wasm issue 700 #6345
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7562c4
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (21.18%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feat/clarity-wasm-develop #6345 +/- ##
=============================================================
- Coverage 21.34% 21.18% -0.17%
=============================================================
Files 526 521 -5
Lines 339891 338650 -1241
Branches 323 0 -323
=============================================================
- Hits 72563 71735 -828
+ Misses 267320 266915 -405
+ Partials 8 0 -8
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This is the stacks-core part of the fix for stacks-network/clarity-wasm#700 .
The bug was due to an oversimplification in the retrieving of the contract containing the defined trait in the case of a dynamic call.
Now, instead of just using the trait name and looking for its definition in the pulled contract containing the function, we deserialize a full
TraitIdentifier
and (if needed) fetch the contract which defines the trait.This fix also needs a clarity-wasm counterpart, which makes a few changes in the compiler, the same change in the runtime (due to the duplication issue) and has the testing for this change.