-
Notifications
You must be signed in to change notification settings - Fork 698
Fix sip 031 test flakiness and refactoring of base types and functions #6336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sip 031 test flakiness and refactoring of base types and functions #6336
Conversation
miner_constructs_replay_block is broken on develop. Hangs forever. So do not think this is a problem with this PR. I also see it failing on other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
e8a60a7
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (73.84%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6336 +/- ##
===========================================
+ Coverage 65.36% 73.84% +8.47%
===========================================
Files 552 552
Lines 351502 351531 +29
===========================================
+ Hits 229768 259575 +29807
+ Misses 121734 91956 -29778
... and 387 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
This patch fixes potential flakiness in sip-031 related integration tests (caused by the usage of get_latest_block_proposal instead of test_observer::get_blocks()) and moves the basic sip-031-related types and functions from stackslib to stacks-common
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml