Skip to content

Fix sip 031 test flakiness and refactoring of base types and functions #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rdeioris
Copy link
Contributor

Description

This patch fixes potential flakiness in sip-031 related integration tests (caused by the usage of get_latest_block_proposal instead of test_observer::get_blocks()) and moves the basic sip-031-related types and functions from stackslib to stacks-common

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris requested review from a team as code owners July 28, 2025 06:04
@rdeioris rdeioris requested review from jcnelson, obycode and hstove July 28, 2025 06:04
@rdeioris rdeioris self-assigned this Jul 28, 2025
@jferrant
Copy link
Contributor

miner_constructs_replay_block is broken on develop. Hangs forever. So do not think this is a problem with this PR. I also see it failing on other PRs.

@hstove hstove linked an issue Jul 29, 2025 that may be closed by this pull request
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rdeioris rdeioris enabled auto-merge August 6, 2025 14:40
@rdeioris rdeioris disabled auto-merge August 6, 2025 14:41
@rdeioris rdeioris enabled auto-merge August 6, 2025 14:41
@rdeioris rdeioris added this pull request to the merge queue Aug 6, 2025
Merged via the queue into stacks-network:develop with commit e8a60a7 Aug 6, 2025
245 of 248 checks passed
@rdeioris rdeioris deleted the fix/sip_031_test_flakiness branch August 6, 2025 15:33
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 6.87500% with 149 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.84%. Comparing base (3ece8b5) to head (8fa1399).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-common/src/types/mod.rs 10.37% 95 Missing ⚠️
stacks-node/src/tests/nakamoto_integrations.rs 0.00% 54 Missing ⚠️

❌ Your project status has failed because the head coverage (73.84%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6336      +/-   ##
===========================================
+ Coverage    65.36%   73.84%   +8.47%     
===========================================
  Files          552      552              
  Lines       351502   351531      +29     
===========================================
+ Hits        229768   259575   +29807     
+ Misses      121734    91956   -29778     
Files with missing lines Coverage Δ
stackslib/src/chainstate/nakamoto/mod.rs 79.31% <ø> (+0.33%) ⬆️
stacks-node/src/tests/nakamoto_integrations.rs 35.44% <0.00%> (-22.13%) ⬇️
stacks-common/src/types/mod.rs 74.90% <10.37%> (-15.26%) ⬇️

... and 387 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ece8b5...8fa1399. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] move SIP-031 coinbase code alongside that of SIP-029
3 participants