Skip to content

Feat/sip 031 Mint-and-transfer per tenure infrastructure #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jul 21, 2025
Merged

Feat/sip 031 Mint-and-transfer per tenure infrastructure #6270

merged 29 commits into from
Jul 21, 2025

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Jul 9, 2025

Description

This is the last step for implementing sip-031 funds emission.

At every new tenure, based on bitcoin height, a set of STX is minted and transferred to the sip-031 boot contract

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@aldur aldur added this to the 3.1.0.0.14 milestone Jul 10, 2025
@aldur aldur moved this to Status: 💻 In Progress in Stacks Core Eng Jul 10, 2025
@aldur aldur changed the base branch from develop to release/3.2.0.0.0-rc1 July 11, 2025 15:36
@hstove hstove linked an issue Jul 16, 2025 that may be closed by this pull request
SIP-031 Coinbase management for last phase #6257
Closed
kantai
kantai reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me -- just a couple comments, and a suggestion once tests are written for this portion.

obycode
obycode reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_nakamoto_empty_block_heuristics is causing a bunch of integration tests to fail. Can you also add an integration test that verifies some coinbase transitions?

@rdeioris
Copy link
Contributor Author

check_nakamoto_empty_block_heuristics is causing a bunch of integration tests to fail. Can you also add an integration test that verifies some coinbase transitions?

right now the logic is broken as only the follower applies the sip-031 logic (not the miner), so the validation fails. I am fixing it.

@rdeioris
Copy link
Contributor Author

@obycode i confirm check_nakamoto_empty_block_heuristics fails due to the presence of the contract deploy at epoch 3.2 activation. Adding a workaround to it.

@rdeioris rdeioris marked this pull request as ready for review July 17, 2025 23:26
@rdeioris rdeioris requested review from a team as code owners July 17, 2025 23:26
@rdeioris rdeioris requested review from obycode and kantai July 21, 2025 05:35
hstove
hstove previously approved these changes Jul 21, 2025
View reviewed changes
@rdeioris rdeioris moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Jul 21, 2025
@obycode
Copy link
Contributor

obycode commented Jul 21, 2025

I think we should definitely keep this - but let's have a hard-coded emissions schedule for public testnet, using the block height that @obycode picks. It's important that we have something that's "real" on testnet.

The problem is that we already do not have the correct epoch activation heights for testnet. The hardcoded values do not match testnet currently.

obycode
obycode previously approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙌

obycode
obycode previously approved these changes Jul 21, 2025
View reviewed changes
@obycode obycode mentioned this pull request Jul 21, 2025
Open
5 tasks
hstove
hstove previously approved these changes Jul 21, 2025
View reviewed changes
@kantai kantai dismissed stale reviews from hstove and obycode via c7a45eb July 21, 2025 19:26
obycode
obycode reviewed Jul 21, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 21, 2025
@wileyj wileyj merged commit df5b222 into stacks-network:release/3.2.0.0.0-rc1 Jul 21, 2025
2 of 3 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Jul 21, 2025
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hstove hstove hstove approved these changes

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

Assignees

@rdeioris rdeioris

Labels
locked sip-031
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.2.0.0.0
Development

Successfully merging this pull request may close these issues.

SIP-031 Coinbase management for last phase
6 participants
@rdeioris @hstove @obycode @kantai @aldur @wileyj