This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Properly parse conversations into alerts #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aponcedeleonch
force-pushed
the
chat-id-alerts
branch
from
48b9227 to
c0385ec
Compare
JAORMX
previously approved these changes
Jan 24, 2025
aponcedeleonch
force-pushed
the
chat-id-alerts
branch
from
c0385ec to
25a67d0
Compare
Closes: #420 This PR introduces: - Have full conversations in alerts. Until now we were only showing the message where the alert came from in `*/alerts` - Match the `chat_id` in the alert conversation to the ones returned in `*/messages` - Fixes a grouping issue in which conversations with secrets were not grouped correctly because of the `REDACTED<>` text.
aponcedeleonch
force-pushed
the
chat-id-alerts
branch
from
47b0782 to
05e3b41
Compare
JAORMX
approved these changes
Jan 24, 2025
peppescg
approved these changes
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #420
This PR introduces:
*/alertschat_idin the alert conversation to the ones returned in*/messagesREDACTED<>text.