Skip to content

fix: filtering out empty answer prompts, alerts #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/Chat.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ export function Chat() {
<ChatBubbleMessage variant="sent" className="bg-zinc-700">
<Markdown className="text-gray-300">
{sanitizeQuestionPrompt({
question: question?.message,
answer: answer?.message,
question: question?.message ?? "",
answer: answer?.message ?? "",
})}
</Markdown>
</ChatBubbleMessage>
</ChatBubble>
<ChatBubble variant="received">
<ChatBubbleAvatar fallback="AI" />
<ChatBubbleMessage variant="received">
<Markdown>{answer?.message}</Markdown>
<Markdown>{answer?.message ?? ""}</Markdown>
</ChatBubbleMessage>
</ChatBubble>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/PromptList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,18 @@ export function PromptList({ prompts }: { prompts: Prompt[] }) {
to={`/prompt/${prompt.chat_id}`}
className={clsx(
`text-gray-800 text-sm truncate hover:text-gray-500`,
{ "font-bold": currentPromptId === prompt.chat_id }
{ "font-bold": currentPromptId === prompt.chat_id },
)}
>
{extractTitleFromMessage(
prompt.question_answers?.[0].question.message
prompt.question_answers?.[0].question?.message
? sanitizeQuestionPrompt({
question:
prompt.question_answers?.[0].question.message,
answer:
prompt.question_answers?.[0]?.answer?.message ?? "",
})
: `Prompt ${prompt.conversation_timestamp}`
: `Prompt ${prompt.conversation_timestamp}`,
)}
</Link>
</li>
Expand Down
12 changes: 9 additions & 3 deletions src/hooks/useAlertsStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ export const useAlertsStore = create<AlertState>((set, get) => ({
set({ loading: true });
const alerts = await getAlerts();
set({
alerts: alerts.filter((alert) => alert.trigger_category === "critical"),
alerts: alerts
.filter((alert) => alert.trigger_category === "critical")
.filter((alert) =>
alert.conversation.question_answers.every(
(item) => item.answer && item.question,
),
),
loading: false,
});
get().updateFilteredAlerts();
Expand Down Expand Up @@ -57,11 +63,11 @@ export const useAlertsStore = create<AlertState>((set, get) => ({
})
.sort(
(a, b) =>
new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime()
new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime(),
)
: alerts.sort(
(a, b) =>
new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime()
new Date(b.timestamp).getTime() - new Date(a.timestamp).getTime(),
);

set({ filteredAlerts });
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useBreadcrumb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function useBreadcrumb() {
if (match?.path === "/prompt/") {
try {
const chat = prompts.find((prompt) => prompt.chat_id === currentPromptId);
const title = chat?.question_answers?.[0].question.message ?? "";
const title = chat?.question_answers?.[0].question?.message ?? "";

const sanitized = sanitizeQuestionPrompt({
question: title,
Expand Down
7 changes: 6 additions & 1 deletion src/hooks/usePromptsStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ export const usePromptsStore = create<PromptState>((set) => ({
fetchPrompts: async () => {
set({ loading: true });
const prompts = await getPrompts();
set({ prompts, loading: false });
set({
prompts: prompts.filter((prompt) =>
prompt.question_answers?.every((item) => item.answer && item.question),
),
loading: false,
});
},
}));
54 changes: 26 additions & 28 deletions src/lib/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,25 @@ export function groupPromptsByRelativeDate(prompts: Prompt[]) {
const promptsSorted = prompts.sort(
(a, b) =>
new Date(b.conversation_timestamp).getTime() -
new Date(a.conversation_timestamp).getTime()
new Date(a.conversation_timestamp).getTime(),
);

const grouped = promptsSorted.reduce((groups, prompt) => {
const promptDate = new Date(prompt.conversation_timestamp);
const now = new Date();
const differenceInMs = now.getTime() - promptDate.getTime();
const group = getGroup(differenceInMs, promptDate);
const grouped = promptsSorted.reduce(
(groups, prompt) => {
const promptDate = new Date(prompt.conversation_timestamp);
const now = new Date();
const differenceInMs = now.getTime() - promptDate.getTime();
const group = getGroup(differenceInMs, promptDate);

if (!groups[group]) {
groups[group] = [];
}
if (!groups[group]) {
groups[group] = [];
}

groups[group].push(prompt);
return groups;
}, {} as Record<string, Prompt[]>);
groups[group].push(prompt);
return groups;
},
{} as Record<string, Prompt[]>,
);

return grouped;
}
Expand All @@ -82,13 +85,13 @@ export function getAllIssues(alerts: Alert[]) {
}
return acc;
},
{}
{},
);

const maxCount = Math.max(...Object.values(groupedTriggerCounts));

const sortedTagCounts = Object.entries(groupedTriggerCounts).sort(
([, countA], [, countB]) => countB - countA
([, countA], [, countB]) => countB - countA,
);
return { maxCount, sortedTagCounts };
}
Expand Down Expand Up @@ -120,22 +123,17 @@ export function sanitizeQuestionPrompt({
answer: string;
}) {
try {
// it shouldn't be possible to receive the prompt answer without a question
if (!answer) return question;

// Check if 'answer' is truthy; if so, try to find and return the text after "Query:"
if (answer) {
const index = question.indexOf("Query:");
if (index !== -1) {
// Return the substring starting right after the first occurrence of "Query:"
// Adding the length of "Query:" to the index to start after it
return question.substring(index + "Query:".length).trim();
} else {
// If there is no "Query:" in the string, log the condition and return an empty string
console.log("No 'Query:' found in the question.");
return "";
}
} else {
// If 'answer' is not provided or falsy, return the original question
return question;
const index = question.indexOf("Query:");
if (index !== -1) {
// Return the substring starting right after the first occurrence of "Query:"
// Adding the length of "Query:" to the index to start after it
return question.substring(index + "Query:".length).trim();
}
return answer;
} catch (error) {
// Log the error and return the original question as a fallback
console.error("Error processing the question:", error);
Expand Down
4 changes: 2 additions & 2 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ export type Chat = {
message: string;
timestamp: string;
message_id: string;
};
} | null;
answer: {
message: string;
timestamp: string;
message_id: string;
};
} | null;
};
Loading