-
Notifications
You must be signed in to change notification settings - Fork 17
fix(key_flow): Add 5 second leeway to refresh access tokens early #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems this breaks the Is increasing token lifetimes (5+ seconds) in those tests a feasible approach? |
thanks for this, we have been suffering expired tokens every now and then <3 |
Moved the new variable to Now the This raises questions about the robustness of these tests though, as they do not call the Should I create a separate issue or is this the intended way for the tests to run? |
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Looks good, do you want to add the changelogs as well then this can be merged.
Regarding your open topic, I created a separate ticket on our side to have a look at this.
Changelog has been updated. |
Co-authored-by: Alexander Dahmen <[email protected]>
Co-authored-by: Alexander Dahmen <[email protected]>
Co-authored-by: Alexander Dahmen <[email protected]>
Co-authored-by: Alexander Dahmen <[email protected]>
Description
This PR attempts to fix #2193
Checklist
make fmt
examples/
directory)make test
(will be checked by CI)make lint
(will be checked by CI)