Skip to content

feat(ske): Region adjustment #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

feat(ske): Region adjustment #842

merged 1 commit into from
Jul 7, 2025

Conversation

Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Jul 7, 2025

Description

relates to STACKITCLI-187

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel force-pushed the ft/region-adjustment-ske branch from 4414487 to 9c9fd12 Compare July 7, 2025 13:52
Signed-off-by: Alexander Dahmen <[email protected]>
@Fyusel Fyusel force-pushed the ft/region-adjustment-ske branch from 9c9fd12 to ce57a19 Compare July 7, 2025 15:56
@Fyusel Fyusel requested a review from a team as a code owner July 7, 2025 15:56
@Fyusel Fyusel enabled auto-merge (squash) July 7, 2025 16:00
@Fyusel Fyusel merged commit 99638ed into main Jul 7, 2025
5 checks passed
@Fyusel Fyusel deleted the ft/region-adjustment-ske branch July 7, 2025 16:01
Copy link

github-actions bot commented Jul 7, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create 31.11% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/delete 25.58% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/describe 43.86% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/generate-payload 44.68% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list 38.75% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/update 36.99% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/credentials/complete-rotation 25.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/credentials/start-rotation 25.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/create 32.43% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/login 8.91% (-0.18%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options 35.86% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/utils 93.39% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create/create.go 31.11% (ø) 90 28 62
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/delete/delete.go 25.58% (ø) 43 11 32
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/describe/describe.go 43.86% (ø) 57 25 32
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/generate-payload/generate_payload.go 44.68% (ø) 47 21 26
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list/list.go 38.75% (ø) 80 31 49
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/update/update.go 36.99% (ø) 73 27 46
github.com/stackitcloud/stackit-cli/internal/cmd/ske/credentials/complete-rotation/complete_rotation.go 25.00% (ø) 44 11 33
github.com/stackitcloud/stackit-cli/internal/cmd/ske/credentials/start-rotation/start_rotation.go 25.00% (ø) 44 11 33
github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/create/create.go 32.43% (ø) 111 36 75
github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/login/login.go 8.91% (-0.18%) 101 (+2) 9 92 (+2) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/options.go 35.86% (ø) 145 52 93
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/client/client.go 0.00% (ø) 16 (-1) 0 16 (-1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/utils/utils.go 93.39% (ø) 121 113 8

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/generate-payload/generate_payload_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/credentials/complete-rotation/complete_rotation_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/credentials/start-rotation/start_rotation_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/login/login_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/options/options_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants