git cmd structure, adding flavor and acl to create flow, create list flavor endpoint #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rubenhoenle merged 6 commits into stackitcloud:main from ivan-tejero:main

Jul 17, 2025

Contributor

ivan-tejero commented Jul 7, 2025

PR to add flavor and acl fields to git instance creation flow, adding flavor list endpoint and changing the cmd structure for git

ivan-tejero requested review from marceljk, Fyusel and rubenhoenle as code owners

July 7, 2025 12:39

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/flavor/flavor.go Outdated Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/flavor/flavor.go Outdated Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/instance/instance.go Outdated Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/instance/instance.go Outdated Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/flavor/flavor.go Outdated Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/instance/instance.go Outdated Show resolved Hide resolved

Member

rubenhoenle commented Jul 9, 2025

@ivan-tejero please check the CI pipeline. The docs aren't up-to-date.

Please run $ make generate-docs and push the changes.

ivan-tejero requested a review from a team as a code owner

July 9, 2025 12:27

ivan-tejero requested a review from rubenhoenle

July 9, 2025 12:32

Contributor Author

ivan-tejero commented Jul 11, 2025

All code changes done, and pipeline suggestions. Waiting for pipeline to be retriggered

Contributor Author

ivan-tejero commented Jul 14, 2025

@rubenhoenle any updates in this PR?

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/instance/instance.go Outdated Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/git/instance/instance.go Outdated Show resolved Hide resolved

ivan-tejero requested a review from rubenhoenle

July 17, 2025 09:07

rubenhoenle self-assigned this

ivan-tejero added 6 commits

July 17, 2025 11:41


          git cmd structure, adding flavor and acl to create flow, create list …

378ec95

…flavor endpoint


          git cmd structure, adding flavor and acl to create flow, create list …

9050ecc

…flavor endpoint


          git cmd structure, adding flavor and acl to create flow, create list …

3bae703

…flavor endpoint


          adding docs and suggested changes

5e96f01


          go imports

eb0a7e7


          change import delete2 to delete

rubenhoenle force-pushed the main branch from 7a4c74d to 6654972 Compare

July 17, 2025 09:41

Member

rubenhoenle commented Jul 17, 2025

@ivan-tejero looks good, thanks for your contribution! 😄

rubenhoenle enabled auto-merge (squash)

July 17, 2025 09:45

rubenhoenle disabled auto-merge

July 17, 2025 09:49

rubenhoenle enabled auto-merge (squash)

July 17, 2025 09:50

rubenhoenle approved these changes

View reviewed changes

rubenhoenle merged commit 32bd967 into stackitcloud:main

4 of 5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet