Skip to content

Add stackit git commands: list, describe, create and delete. #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 13, 2025

Conversation

peremanent
Copy link
Contributor

Description

  • Added the following commands for Stackit Git service:
    • list, describe, create and delete.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

* Add stackit git list instances command

* Add stackit git list instances command

* Git. Move list package and add describe command

* Stackit Git create instance command

* Add delete command to the stackit git cli
@rubenhoenle
Copy link
Member

@peremanent FYI: The CI run failed because docs aren't up to-to-date. Please re-generate the docs with make generate-docs

…eneration

* Stop using new variables for the globalflags.ProjectIdFlag and minor issues

* Add docs of the stackit git instance command
@peremanent peremanent requested a review from rubenhoenle May 6, 2025 11:00
Copy link
Contributor

@bahkauv70 bahkauv70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor stuff. When this is fixed, the PR may be merged

@peremanent peremanent requested a review from bahkauv70 May 9, 2025 06:41
… *params.CmdParams attribute

Merge with upstream and modify stackit git commands to use new params *params.CmdParams attribute
Copy link
Contributor

@bahkauv70 bahkauv70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, only the pipeline fails. The reason could be, that snyk is not able to handle the toolchain option from go.mod. Could you please remove this and try again? If the pipeline is green, we can merge this

@bahkauv70
Copy link
Contributor

synk still has an issue, we'll check this again

@bahkauv70 bahkauv70 enabled auto-merge (squash) May 13, 2025 11:03
@bahkauv70 bahkauv70 merged commit 09684be into stackitcloud:main May 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants