Skip to content

Feat/stackitcli 183 onboarding alb project api #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bahkauv70
Copy link
Contributor

@bahkauv70 bahkauv70 commented Apr 10, 2025

Description

The application load balancer api provides additional metadata information calls to retrieve quotas and plans. This PR allows retrieving those.
⚠️ Mind the non-standard target branch

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@bahkauv70 bahkauv70 force-pushed the feat/stackitcli-183-onboarding-alb-project-api branch 7 times, most recently from 4219dee to 3381f64 Compare April 10, 2025 18:06
@bahkauv70 bahkauv70 changed the base branch from main to feat/stackitcli-184-onboarding-alb-credentials April 10, 2025 20:09
@bahkauv70 bahkauv70 force-pushed the feat/stackitcli-184-onboarding-alb-credentials branch from 05c82eb to fb4152b Compare April 11, 2025 06:26
@bahkauv70 bahkauv70 force-pushed the feat/stackitcli-183-onboarding-alb-project-api branch from 3381f64 to 8f1f4a2 Compare April 11, 2025 06:27
@bahkauv70 bahkauv70 marked this pull request as ready for review April 11, 2025 07:09
Copy link
Contributor

@marceljk marceljk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only a few nitpicks in the documentation

@bahkauv70 bahkauv70 force-pushed the feat/stackitcli-184-onboarding-alb-credentials branch from fb4152b to 83ad667 Compare April 14, 2025 10:42
@bahkauv70 bahkauv70 force-pushed the feat/stackitcli-183-onboarding-alb-project-api branch from 6fcea41 to e441f61 Compare April 14, 2025 10:43
@bahkauv70 bahkauv70 merged commit 2ece9e5 into feat/stackitcli-184-onboarding-alb-credentials Apr 14, 2025
3 checks passed
@bahkauv70 bahkauv70 deleted the feat/stackitcli-183-onboarding-alb-project-api branch April 14, 2025 11:39
bahkauv70 added a commit that referenced this pull request Apr 14, 2025
* feat(credentials)

* feat(credentials): code cleanup

* feat(credentials): updated documentation

* feat(credentials): bug fixes

* feat(credentials): updated docs

* feat(credentials): fixed testcases

* feat(credentials): code cleanup

* feat(alb project): support for quota and plans

* feat(alb project): updated documentation

* feat(alb project): review findings
bahkauv70 added a commit that referenced this pull request Apr 14, 2025
* feat(credentials)

* feat(credentials): code cleanup

* feat(credentials): updated documentation

* feat(credentials): bug fixes

* feat(credentials): updated docs

* feat(credentials): fixed testcases

* feat(credentials): code cleanup

* feat(alb project): support for quota and plans

* feat(alb project): updated documentation

* feat(alb project): review findings
bahkauv70 added a commit that referenced this pull request Apr 14, 2025
* feat(credentials): list command

* feat(credentials): commands working

* feat(credentials): corrected chaining of commands

* feat(credentials): fixed linter issues

* feat(credentials): command implementation

* feat(credentials): code cleanup

* feat(credentials): updated documentation

* feat(credentials): bug fixes

* feat(credentials): updated docs

* feat(credentials): fixed testcases

* feat(credentials): code cleanup

* Feat/stackitcli 183 onboarding alb project api (#700)

* feat(credentials)

* feat(credentials): code cleanup

* feat(credentials): updated documentation

* feat(credentials): bug fixes

* feat(credentials): updated docs

* feat(credentials): fixed testcases

* feat(credentials): code cleanup

* feat(alb project): support for quota and plans

* feat(alb project): updated documentation

* feat(alb project): review findings

* feat(credentials): Integrated review findings

* feat(credentials): more review findings
bahkauv70 added a commit that referenced this pull request Apr 14, 2025
* feat(alb): list command

* feat(alb): bugfix

* feat(alb): add template support

* feat(alb): create command

* feat(alb): fix testcases

* feat(alb): add update

* feat(alb): add describe command

* feat(alb): delete command

* feat(alb): fix linter issues

* feat(alb): code cleanup

* feat(alb): template support for pool

* feat(alb): added target pool update

* feat(alb): add list of errors to describe output

* feat(alb): Include number of errors

* feat(alb): retrieve the existing loadbalancer config to evaluate the current version

* feat(alb): switch source of templates to yaml to allow comments

* feat(alb): corrected template for target pool

* feat(alb): retrieve target pool name from configuration file

* feat(alb): updated documentation

* feat(alb): add missing delete confirmation

* feat(alb): review findings

* Feat/stackitcli 184 onboarding alb credentials (#696)

* feat(credentials): list command

* feat(credentials): commands working

* feat(credentials): corrected chaining of commands

* feat(credentials): fixed linter issues

* feat(credentials): command implementation

* feat(credentials): code cleanup

* feat(credentials): updated documentation

* feat(credentials): bug fixes

* feat(credentials): updated docs

* feat(credentials): fixed testcases

* feat(credentials): code cleanup

* Feat/stackitcli 183 onboarding alb project api (#700)

* feat(credentials)

* feat(credentials): code cleanup

* feat(credentials): updated documentation

* feat(credentials): bug fixes

* feat(credentials): updated docs

* feat(credentials): fixed testcases

* feat(credentials): code cleanup

* feat(alb project): support for quota and plans

* feat(alb project): updated documentation

* feat(alb project): review findings

* feat(credentials): Integrated review findings

* feat(credentials): more review findings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants