-
Notifications
You must be signed in to change notification settings - Fork 21
Feat/stackitcli 183 onboarding alb project api #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bahkauv70
merged 10 commits into
feat/stackitcli-184-onboarding-alb-credentials
from
feat/stackitcli-183-onboarding-alb-project-api
Apr 14, 2025
Merged
Feat/stackitcli 183 onboarding alb project api #700
bahkauv70
merged 10 commits into
feat/stackitcli-184-onboarding-alb-credentials
from
feat/stackitcli-183-onboarding-alb-project-api
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4219dee
to
3381f64
Compare
05c82eb
to
fb4152b
Compare
3381f64
to
8f1f4a2
Compare
marceljk
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good only a few nitpicks in the documentation
fb4152b
to
83ad667
Compare
6fcea41
to
e441f61
Compare
marceljk
approved these changes
Apr 14, 2025
2ece9e5
into
feat/stackitcli-184-onboarding-alb-credentials
3 checks passed
bahkauv70
added a commit
that referenced
this pull request
Apr 14, 2025
* feat(credentials) * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * feat(alb project): support for quota and plans * feat(alb project): updated documentation * feat(alb project): review findings
bahkauv70
added a commit
that referenced
this pull request
Apr 14, 2025
* feat(credentials) * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * feat(alb project): support for quota and plans * feat(alb project): updated documentation * feat(alb project): review findings
bahkauv70
added a commit
that referenced
this pull request
Apr 14, 2025
* feat(credentials): list command * feat(credentials): commands working * feat(credentials): corrected chaining of commands * feat(credentials): fixed linter issues * feat(credentials): command implementation * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * Feat/stackitcli 183 onboarding alb project api (#700) * feat(credentials) * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * feat(alb project): support for quota and plans * feat(alb project): updated documentation * feat(alb project): review findings * feat(credentials): Integrated review findings * feat(credentials): more review findings
bahkauv70
added a commit
that referenced
this pull request
Apr 14, 2025
* feat(alb): list command * feat(alb): bugfix * feat(alb): add template support * feat(alb): create command * feat(alb): fix testcases * feat(alb): add update * feat(alb): add describe command * feat(alb): delete command * feat(alb): fix linter issues * feat(alb): code cleanup * feat(alb): template support for pool * feat(alb): added target pool update * feat(alb): add list of errors to describe output * feat(alb): Include number of errors * feat(alb): retrieve the existing loadbalancer config to evaluate the current version * feat(alb): switch source of templates to yaml to allow comments * feat(alb): corrected template for target pool * feat(alb): retrieve target pool name from configuration file * feat(alb): updated documentation * feat(alb): add missing delete confirmation * feat(alb): review findings * Feat/stackitcli 184 onboarding alb credentials (#696) * feat(credentials): list command * feat(credentials): commands working * feat(credentials): corrected chaining of commands * feat(credentials): fixed linter issues * feat(credentials): command implementation * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * Feat/stackitcli 183 onboarding alb project api (#700) * feat(credentials) * feat(credentials): code cleanup * feat(credentials): updated documentation * feat(credentials): bug fixes * feat(credentials): updated docs * feat(credentials): fixed testcases * feat(credentials): code cleanup * feat(alb project): support for quota and plans * feat(alb project): updated documentation * feat(alb project): review findings * feat(credentials): Integrated review findings * feat(credentials): more review findings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The application load balancer api provides additional metadata information calls to retrieve quotas and plans. This PR allows retrieving those.
⚠️ Mind the non-standard target branch
Checklist
make fmt
make generate-docs
(will be checked by CI)make test
(will be checked by CI)make lint
(will be checked by CI)