Skip to content

Onboard "region" global flag for region-specific requests #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

marceljk
Copy link
Contributor

@marceljk marceljk commented Jan 8, 2025

Add global flag "region" to set the region for region-specific requests

Copy link
Contributor

@bahkauv70 bahkauv70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute defaultNodepoolAvailabilityZone in pkg/services/ske/utils/utils.go is currently set to "eu01-3". Must this be changed to the global region flag as well?

@vicentepinto98
Copy link
Contributor

The attribute defaultNodepoolAvailabilityZone in pkg/services/ske/utils/utils.go is currently set to "eu01-3". Must this be changed to the global region flag as well?

Availability zone and region are different concepts as far as I know, I wouldn't change this one

@marceljk
Copy link
Contributor Author

marceljk commented Jan 8, 2025

The attribute defaultNodepoolAvailabilityZone in pkg/services/ske/utils/utils.go is currently set to "eu01-3". Must this be changed to the global region flag as well?

Availability zone and region are different concepts as far as I know, I wouldn't change this one

I have checked its usage. It is used by the ske cluster create command when a user does not provide a payload to it. I'm not sure if this might cause errors in the future if a user sets the region to eu02 and doesn't provide a payload for the ske cluster.

@vicentepinto98
Copy link
Contributor

That's a good point, it could create issues. When SKE is available in the new region, we should check with them what should be the default value for the availability zone in that case and have some default mapping

@marceljk marceljk merged commit 5ba6565 into main Jan 10, 2025
3 checks passed
@marceljk marceljk deleted the feature/add-region-globalflag branch January 10, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants