Skip to content

Commit 8fe07a3

Browse files
committed
implement review feedback
1 parent f709f08 commit 8fe07a3

File tree

9 files changed

+79
-1
lines changed

9 files changed

+79
-1
lines changed

internal/cmd/beta/network-area/list/list_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,20 @@ func TestOutputResult(t *testing.T) {
202202
args: args{},
203203
wantErr: false,
204204
},
205+
{
206+
name: "empty network areas slice",
207+
args: args{
208+
networkAreas: []iaas.NetworkArea{},
209+
},
210+
wantErr: false,
211+
},
212+
{
213+
name: "empty network area in network areas slice",
214+
args: args{
215+
networkAreas: []iaas.NetworkArea{{}},
216+
},
217+
wantErr: false,
218+
},
205219
}
206220
p := print.NewPrinter()
207221
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/network-range/create/create_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,13 @@ func TestOutputResult(t *testing.T) {
232232
args: args{},
233233
wantErr: false,
234234
},
235+
{
236+
name: "empty network range",
237+
args: args{
238+
networkRange: iaas.NetworkRange{},
239+
},
240+
wantErr: false,
241+
},
235242
}
236243
p := print.NewPrinter()
237244
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/network-range/list/list.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
1616
iaasUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/utils"
1717
"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
18+
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
1819
"github.com/stackitcloud/stackit-sdk-go/services/iaas"
1920

2021
"github.com/spf13/cobra"
@@ -164,7 +165,7 @@ func outputResult(p *print.Printer, outputFormat string, networkRanges []iaas.Ne
164165
table.SetHeader("ID", "Network Range")
165166

166167
for _, networkRange := range networkRanges {
167-
table.AddRow(*networkRange.NetworkRangeId, *networkRange.Prefix)
168+
table.AddRow(utils.PtrString(networkRange.NetworkRangeId), utils.PtrString(networkRange.Prefix))
168169
}
169170

170171
p.Outputln(table.Render())

internal/cmd/beta/network-area/network-range/list/list_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,20 @@ func TestOutputResult(t *testing.T) {
226226
args: args{},
227227
wantErr: false,
228228
},
229+
{
230+
name: "empty network ranges slice",
231+
args: args{
232+
networkRanges: []iaas.NetworkRange{},
233+
},
234+
wantErr: false,
235+
},
236+
{
237+
name: "empty network range in network ranges slice",
238+
args: args{
239+
networkRanges: []iaas.NetworkRange{{}},
240+
},
241+
wantErr: false,
242+
},
229243
}
230244
p := print.NewPrinter()
231245
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/route/create/create_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,13 @@ func TestOutputResult(t *testing.T) {
278278
args: args{},
279279
wantErr: false,
280280
},
281+
{
282+
name: "empty route",
283+
args: args{
284+
route: iaas.Route{},
285+
},
286+
wantErr: false,
287+
},
281288
}
282289
p := print.NewPrinter()
283290
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/route/describe/describe_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,13 @@ func TestOutputResult(t *testing.T) {
250250
args: args{},
251251
wantErr: false,
252252
},
253+
{
254+
name: "empty route",
255+
args: args{
256+
route: iaas.Route{},
257+
},
258+
wantErr: false,
259+
},
253260
}
254261
p := print.NewPrinter()
255262
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/route/list/list_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,20 @@ func TestOutputResult(t *testing.T) {
226226
args: args{},
227227
wantErr: false,
228228
},
229+
{
230+
name: "empty route slice",
231+
args: args{
232+
routes: []iaas.Route{},
233+
},
234+
wantErr: false,
235+
},
236+
{
237+
name: "empty route in routes slice",
238+
args: args{
239+
routes: []iaas.Route{{}},
240+
},
241+
wantErr: false,
242+
},
229243
}
230244
p := print.NewPrinter()
231245
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/route/update/update_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,13 @@ func TestOutputResult(t *testing.T) {
284284
args: args{},
285285
wantErr: false,
286286
},
287+
{
288+
name: "empty route",
289+
args: args{
290+
route: iaas.Route{},
291+
},
292+
wantErr: false,
293+
},
287294
}
288295
p := print.NewPrinter()
289296
p.Cmd = NewCmd(p)

internal/cmd/beta/network-area/update/update_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,13 @@ func TestOutputResult(t *testing.T) {
283283
args: args{},
284284
wantErr: false,
285285
},
286+
{
287+
name: "empty network area",
288+
args: args{
289+
networkArea: iaas.NetworkArea{},
290+
},
291+
wantErr: false,
292+
},
286293
}
287294
p := print.NewPrinter()
288295
p.Cmd = NewCmd(p)

0 commit comments

Comments
 (0)