fix: consistent else if-clause for labels

marceljk · marceljk · commit f709f08079e2 · 2025-02-20T10:36:27.000+01:00
diff --git a/internal/cmd/beta/network-area/create/create.go b/internal/cmd/beta/network-area/create/create.go
@@ -83,8 +83,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				if err != nil {
 					p.Debug(print.ErrorLevel, "get organization name: %v", err)
 					orgLabel = *model.OrganizationId
-				}
-				if orgLabel == "" {
+				} else if orgLabel == "" {
 					orgLabel = *model.OrganizationId
 				}
 			} else {
diff --git a/internal/cmd/beta/network-area/delete/delete.go b/internal/cmd/beta/network-area/delete/delete.go
@@ -62,8 +62,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get network area name: %v", err)
 				networkAreaLabel = model.AreaId
-			}
-			if networkAreaLabel == "" {
+			} else if networkAreaLabel == "" {
 				networkAreaLabel = model.AreaId
 			}
 
diff --git a/internal/cmd/beta/network-area/list/list.go b/internal/cmd/beta/network-area/list/list.go
@@ -80,8 +80,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 					if err != nil {
 						p.Debug(print.ErrorLevel, "get organization name: %v", err)
 						orgLabel = *model.OrganizationId
-					}
-					if orgLabel == "" {
+					} else if orgLabel == "" {
 						orgLabel = *model.OrganizationId
 					}
 				} else {
diff --git a/internal/cmd/beta/network-area/network-range/delete/delete.go b/internal/cmd/beta/network-area/network-range/delete/delete.go
@@ -60,16 +60,14 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get network area name: %v", err)
 				networkAreaLabel = *model.NetworkAreaId
-			}
-			if networkAreaLabel == "" {
+			} else if networkAreaLabel == "" {
 				networkAreaLabel = *model.NetworkAreaId
 			}
 			networkRangeLabel, err := iaasUtils.GetNetworkRangePrefix(ctx, apiClient, *model.OrganizationId, *model.NetworkAreaId, model.NetworkRangeId)
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get network range prefix: %v", err)
 				networkRangeLabel = model.NetworkRangeId
-			}
-			if networkRangeLabel == "" {
+			} else if networkRangeLabel == "" {
 				networkRangeLabel = model.NetworkRangeId
 			}
 
diff --git a/internal/cmd/beta/network-area/network-range/list/list.go b/internal/cmd/beta/network-area/network-range/list/list.go
@@ -79,8 +79,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				if err != nil {
 					p.Debug(print.ErrorLevel, "get organization name: %v", err)
 					networkAreaLabel = *model.NetworkAreaId
-				}
-				if networkAreaLabel == "" {
+				} else if networkAreaLabel == "" {
 					networkAreaLabel = *model.NetworkAreaId
 				}
 				p.Info("No network ranges found for SNA %q\n", networkAreaLabel)
diff --git a/internal/cmd/beta/network-area/route/create/create.go b/internal/cmd/beta/network-area/route/create/create.go
@@ -73,8 +73,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get network area name: %v", err)
 				networkAreaLabel = *model.NetworkAreaId
-			}
-			if networkAreaLabel == "" {
+			} else if networkAreaLabel == "" {
 				networkAreaLabel = *model.NetworkAreaId
 			}
 
diff --git a/internal/cmd/beta/network-area/route/delete/delete.go b/internal/cmd/beta/network-area/route/delete/delete.go
@@ -60,8 +60,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get network area name: %v", err)
 				networkAreaLabel = *model.NetworkAreaId
-			}
-			if networkAreaLabel == "" {
+			} else if networkAreaLabel == "" {
 				networkAreaLabel = *model.NetworkAreaId
 			}
 
diff --git a/internal/cmd/beta/network-area/route/list/list.go b/internal/cmd/beta/network-area/route/list/list.go
@@ -79,8 +79,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				if err != nil {
 					p.Debug(print.ErrorLevel, "get network area name: %v", err)
 					networkAreaLabel = *model.NetworkAreaId
-				}
-				if networkAreaLabel == "" {
+				} else if networkAreaLabel == "" {
 					networkAreaLabel = *model.NetworkAreaId
 				}
 				p.Info("No static routes found for STACKIT Network Area %q\n", networkAreaLabel)
diff --git a/internal/cmd/beta/network-area/route/update/update.go b/internal/cmd/beta/network-area/route/update/update.go
@@ -69,8 +69,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get network area name: %v", err)
 				networkAreaLabel = *model.NetworkAreaId
-			}
-			if networkAreaLabel == "" {
+			} else if networkAreaLabel == "" {
 				networkAreaLabel = *model.NetworkAreaId
 			}
 
diff --git a/internal/cmd/beta/network-area/update/update.go b/internal/cmd/beta/network-area/update/update.go
@@ -75,8 +75,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				if err != nil {
 					p.Debug(print.ErrorLevel, "get organization name: %v", err)
 					orgLabel = *model.OrganizationId
-				}
-				if orgLabel == "" {
+				} else if orgLabel == "" {
 					orgLabel = *model.OrganizationId
 				}
 			} else {

Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`62`	`62`	`if err != nil {`
`63`	`63`	`p.Debug(print.ErrorLevel, "get network area name: %v", err)`
`64`	`64`	`networkAreaLabel = model.AreaId`
`65`		`- }`
`66`		`- if networkAreaLabel == "" {`
	`65`	`+ } else if networkAreaLabel == "" {`
`67`	`66`	`networkAreaLabel = model.AreaId`
`68`	`67`	`}`
`69`	`68`
Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`73`	`73`	`if err != nil {`
`74`	`74`	`p.Debug(print.ErrorLevel, "get network area name: %v", err)`
`75`	`75`	`networkAreaLabel = *model.NetworkAreaId`
`76`		`- }`
`77`		`- if networkAreaLabel == "" {`
	`76`	`+ } else if networkAreaLabel == "" {`
`78`	`77`	`networkAreaLabel = *model.NetworkAreaId`
`79`	`78`	`}`
`80`	`79`
Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`60`	`60`	`if err != nil {`
`61`	`61`	`p.Debug(print.ErrorLevel, "get network area name: %v", err)`
`62`	`62`	`networkAreaLabel = *model.NetworkAreaId`
`63`		`- }`
`64`		`- if networkAreaLabel == "" {`
	`63`	`+ } else if networkAreaLabel == "" {`
`65`	`64`	`networkAreaLabel = *model.NetworkAreaId`
`66`	`65`	`}`
`67`	`66`
Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`69`	`69`	`if err != nil {`
`70`	`70`	`p.Debug(print.ErrorLevel, "get network area name: %v", err)`
`71`	`71`	`networkAreaLabel = *model.NetworkAreaId`
`72`		`- }`
`73`		`- if networkAreaLabel == "" {`
	`72`	`+ } else if networkAreaLabel == "" {`
`74`	`73`	`networkAreaLabel = *model.NetworkAreaId`
`75`	`74`	`}`
`76`	`75`