Skip to content

[DEV-1038] Cloud init lvm growpart #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 5, 2022
Merged

Conversation

g0rgamesh
Copy link
Contributor

  • added growpart functionality for lvm partitions

@g0rgamesh g0rgamesh requested a review from mnasiadka August 29, 2022 12:51
@g0rgamesh g0rgamesh changed the title Cloud init lvm growpart [DEV-1038] Cloud init lvm growpart Aug 29, 2022
@g0rgamesh g0rgamesh requested review from mnasiadka and removed request for mnasiadka August 29, 2022 13:52
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we talk about this in the context of the recent work on a standard Kayobe host image. I want to avoid duplication of work and differing solutions.

@g0rgamesh g0rgamesh requested a review from mnasiadka September 1, 2022 11:07
@markgoddard
Copy link

Given the change in direction for user images, do we still need this?

@g0rgamesh
Copy link
Contributor Author

Given the change in direction for user images, do we still need this?

Of course, not everyone will use non-lvm images. I will also push it upstream later.

@markgoddard
Copy link

They would still need to increase the LVs to make the system usable.

@g0rgamesh
Copy link
Contributor Author

g0rgamesh commented Sep 1, 2022

They would still need to increase the LVs to make the system usable.

Only on rhel family, other families do not have this problem.

@markgoddard
Copy link

They would still need to increase the LVs to make the system usable.

Only on rhel family, other families do not have this problem.

That's for the PVs. The LVs are still small.

@g0rgamesh
Copy link
Contributor Author

g0rgamesh commented Sep 1, 2022

They would still need to increase the LVs to make the system usable.

Only on rhel family, other families do not have this problem.

That's for the PVs. The LVs are still small.

Of course, but if you want to make them bigger you just need to extend them, I would not assume which LVs the user wants to be big. Similarly, if a whole new set of app specific LVs would be needed it can be created immediately.

@mnasiadka
Copy link
Member

They would still need to increase the LVs to make the system usable.

Only on rhel family, other families do not have this problem.

That's for the PVs. The LVs are still small.

Of course, but if you want to make them bigger you just need to extend them, I would not assume which LVs the user wants to be big. Similarly, if a whole new set of app specific LVs would be needed it can be created immediately.

Gents, can we please just have two ,,flavours'' of images? Without LVM and with LVM?
Obviously we have some use for those with LVM, I understand the case for the non-LVM ones - let's just have both, or am I missing some point?

@markgoddard
Copy link

They would still need to increase the LVs to make the system usable.

Only on rhel family, other families do not have this problem.

That's for the PVs. The LVs are still small.

Of course, but if you want to make them bigger you just need to extend them, I would not assume which LVs the user wants to be big. Similarly, if a whole new set of app specific LVs would be needed it can be created immediately.

Gents, can we please just have two ,,flavours'' of images? Without LVM and with LVM? Obviously we have some use for those with LVM, I understand the case for the non-LVM ones - let's just have both, or am I missing some point?

I think we're agreed on that point, I just wondered why we're still spending time on this PR when it's handled by kayobe

@mnasiadka
Copy link
Member

Kayobe is not the only usage for LVM based install in the world, time was already spent, let's merge this - maybe it will come useful somewhere else - we're not planning to use this on production customer installs (so don't worry about different approaches to the same problem). Can we agree to merge this and forget?

@g0rgamesh g0rgamesh merged commit d8a77ce into master Sep 5, 2022
@g0rgamesh g0rgamesh deleted the cloud-init-lvm-growpart branch September 5, 2022 08:20
Alex-Welsh pushed a commit that referenced this pull request Jun 9, 2023
* added cloud-init-growpart-lvm element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants