-
Notifications
You must be signed in to change notification settings - Fork 9
[DEV-1038] Cloud init lvm growpart #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
g0rgamesh
commented
Aug 29, 2022
- added growpart functionality for lvm partitions
elements/cloud-init-growpart-lvm/post-install.d/55-growpart-lvm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we talk about this in the context of the recent work on a standard Kayobe host image. I want to avoid duplication of work and differing solutions.
elements/cloud-init-growpart-lvm/post-install.d/55-growpart-lvm
Outdated
Show resolved
Hide resolved
Given the change in direction for user images, do we still need this? |
Of course, not everyone will use non-lvm images. I will also push it upstream later. |
They would still need to increase the LVs to make the system usable. |
Only on rhel family, other families do not have this problem. |
That's for the PVs. The LVs are still small. |
Of course, but if you want to make them bigger you just need to extend them, I would not assume which LVs the user wants to be big. Similarly, if a whole new set of app specific LVs would be needed it can be created immediately. |
Gents, can we please just have two ,,flavours'' of images? Without LVM and with LVM? |
I think we're agreed on that point, I just wondered why we're still spending time on this PR when it's handled by kayobe |
Kayobe is not the only usage for LVM based install in the world, time was already spent, let's merge this - maybe it will come useful somewhere else - we're not planning to use this on production customer installs (so don't worry about different approaches to the same problem). Can we agree to merge this and forget? |
elements/cloud-init-growpart-lvm/post-install.d/55-growpart-lvm
Outdated
Show resolved
Hide resolved
* added cloud-init-growpart-lvm element