Skip to content

chore: fix monitoring test #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

chore: fix monitoring test #956

merged 2 commits into from
Jun 24, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jun 20, 2025

Description

Small follow-up PR to #955
The PR introduced additional monitoring testing, which was part of unreachable code and therefore wasn't tested. This fixes it.

--- PASS: kuttl (235.86s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-false_use-client-auth-tls-false_openshift-false (133.77s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-true_use-client-auth-tls-false_openshift-false (151.03s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-false_use-client-auth-tls-true_openshift-false (86.24s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3_use-server-tls-true_use-client-auth-tls-true_openshift-false (84.81s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Jun 20, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Jun 20, 2025
@dervoeti dervoeti self-requested a review June 23, 2025 12:22
dervoeti
dervoeti previously approved these changes Jun 23, 2025
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, LGTM otherwise

@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 23, 2025
@xeniape xeniape added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit ca5c56d Jun 24, 2025
17 checks passed
@xeniape xeniape deleted the chore/fix-monitoring-test branch June 24, 2025 05:52
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants