Skip to content

Use graceful shutdown for workers #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 21, 2023
Merged

Use graceful shutdown for workers #461

merged 16 commits into from
Aug 21, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 17, 2023 •
edited
Loading

Description

Fixes #429

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [ ] CRD changes approved - PENDING
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes) https://ci.stackable.tech/job/trino-operator-it-custom/95/

# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

sbernauer
sbernauer commented Aug 17, 2023
View reviewed changes
@sbernauer sbernauer force-pushed the feat/graceful-shutdown branch from b024675 to 62341d7 Compare August 17, 2023 08:24
@maltesander maltesander self-requested a review August 17, 2023 09:50
maltesander
maltesander reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spelling. Maybe we should include our 24h default certificate rotation that kills everything anyways :)?

@sbernauer
Copy link
Member Author

@maltesander ready for another round of review

@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/95/

maltesander
maltesander previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. LGTM otherwise if operator-rs is released!

@sbernauer sbernauer force-pushed the feat/graceful-shutdown branch from 3867cfe to b426652 Compare August 18, 2023 05:51
@sbernauer sbernauer requested a review from maltesander August 18, 2023 09:42
maltesander
maltesander approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer sbernauer added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit cbd92dc Aug 21, 2023
@sbernauer sbernauer deleted the feat/graceful-shutdown branch August 21, 2023 14:38
@sbernauer sbernauer mentioned this pull request Aug 25, 2023
Merged
@sbernauer sbernauer mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
release/23.11.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support worker graceful shutdown
3 participants
@sbernauer @maltesander @lfrancke