Skip to content

OpenID Connect Support #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siegfriedweber merged 44 commits into from
Jan 31, 2024
Merged

OpenID Connect Support #423

siegfriedweber merged 44 commits into from
Jan 31, 2024

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 17, 2023 •
edited
Loading

Description

Closes #405

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer mentioned this pull request Nov 17, 2023
Open
@fhennig
Copy link
Contributor

fhennig commented Nov 29, 2023

This PR might close this ticket: #405

sbernauer
sbernauer commented Dec 5, 2023
View reviewed changes
@NickLarsenNZ NickLarsenNZ changed the title Support OIDC OpenID Connect Support Dec 7, 2023
sbernauer
sbernauer commented Jan 12, 2024
View reviewed changes
@siegfriedweber siegfriedweber self-assigned this Jan 12, 2024
@siegfriedweber siegfriedweber mentioned this pull request Jan 29, 2024
Merged
@siegfriedweber siegfriedweber requested a review from a team January 30, 2024 07:56
@siegfriedweber siegfriedweber marked this pull request as ready for review January 30, 2024 07:57
@siegfriedweber
Copy link
Member

siegfriedweber commented Jan 30, 2024

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/superset-operator-it-custom/54/

@razvan razvan requested review from razvan and removed request for a team January 30, 2024 11:03
razvan
razvan reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass, I'll wait with approval until the op-rs version is updated.

razvan
razvan previously approved these changes Jan 31, 2024
View reviewed changes
@siegfriedweber siegfriedweber requested a review from razvan January 31, 2024 09:44
@siegfriedweber siegfriedweber added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 30f76ca Jan 31, 2024
@siegfriedweber siegfriedweber deleted the feat/oidc branch January 31, 2024 10:46
@maltesander maltesander mentioned this pull request Jan 31, 2024
Merged
@Maleware Maleware mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber left review comments

@razvan razvan razvan approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenID Connect support

6 participants

@sbernauer @fhennig @siegfriedweber @razvan @NickLarsenNZ