Skip to content

[Merged by Bors] - restructured usage guide & new landing page #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - restructured usage guide & new landing page #344

wants to merge 17 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Mar 27, 2023 •
edited
Loading

Description

💻 preview 💻

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 self-requested a review March 28, 2023 12:24
@fhennig fhennig marked this pull request as ready for review March 28, 2023 12:24
adwk67
adwk67 requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice summary! Just a few minor things.

fhennig and others added 14 commits March 28, 2023 16:07
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
b1ab658 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
f6604a3 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
cf59daa 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
6e6790c 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
f337c71 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
e942c16 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/index.adoc
dc1b61b 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/usage-guide/security.adoc
a73c714 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/usage-guide/configuration-environm…
2f4f50a 
…ent-overrides.adoc

Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/usage-guide/connecting-druid.adoc
43f6d72 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/usage-guide/security.adoc
8ede966 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/usage-guide/security.adoc
87c97bd 
Co-authored-by: Andrew Kenworthy <[email protected]>
@fhennig @adwk67
Update docs/modules/superset/pages/usage-guide/security.adoc
68959b4 
Co-authored-by: Andrew Kenworthy <[email protected]>
Updated changelog
1650271
adwk67
adwk67 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@fhennig
Copy link
Contributor Author

fhennig commented Mar 28, 2023

bors merge

bors bot pushed a commit that referenced this pull request Mar 28, 2023
@fhennig
restructured usage guide & new landing page (#344)
2553597 
# Description

:computer: [preview](https://deploy-preview-374--stackable-docs.netlify.app/home/nightly/superset/index.html) 💻 



Co-authored-by: Felix Hennig <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 28, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title restructured usage guide & new landing page [Merged by Bors] - restructured usage guide & new landing page Mar 28, 2023
@bors bors bot closed this Mar 28, 2023
@bors bors bot deleted the docs-new-landing-page branch March 28, 2023 14:38
@fhennig fhennig mentioned this pull request Mar 28, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @adwk67