Skip to content

Conversation

sbernauer
Copy link
Member

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer requested a review from Techassi August 18, 2025 09:36
@sbernauer sbernauer self-assigned this Aug 18, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 18, 2025
@Techassi Techassi changed the title fix: Use configurable versioned crate instead of hardcoding it fix(stackable-versioned): Use crate override in generated code Aug 18, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 18, 2025
@sbernauer sbernauer requested a review from Techassi August 18, 2025 09:59
@sbernauer sbernauer added this pull request to the merge queue Aug 18, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 18, 2025
Merged via the queue into main with commit e723c30 Aug 18, 2025
8 checks passed
@sbernauer sbernauer deleted the fix/stackable-versioned-import branch August 18, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants