Skip to content

Conversation

@ahoarau
Copy link
Contributor

@ahoarau ahoarau commented Dec 3, 2025

Description

This PR fixes the RTSan integration, not checking anything at runtime with [[clang::nonallocating]].
Replaces the call by a manual call to the realtime sanitizer instead.
This is a current limitation of RTSan/FunctionEffects known by the authors.

Fixes #2809

Checklist

  • I have run pre-commit run --all-files or pixi run lint
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have made corresponding changes to the doxygen documentation
  • I have added tests that prove my fix or feature works
  • I have updated the CHANGELOG or added the "no changelog" label if it's a CI-related issue
  • I have updated the README credits section

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@ahoarau ahoarau marked this pull request as draft December 3, 2025 21:06
nonblocking to trigger the rtsan (nonallocating is only for compile-timeà
noexcept to avoid a compile warning
static local variables uses a pthread_mutex_lock() which causes rtsan to panic. Let's find a good alternative either by configuring rtsan or updating pinocchio code.
@ahoarau ahoarau marked this pull request as ready for review December 4, 2025 11:56
@jorisv
Copy link
Contributor

jorisv commented Dec 5, 2025

No need to write a changelog entry because this fix some unreleased feature

@jorisv jorisv merged commit 294c62f into stack-of-tasks:devel Dec 5, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants